Skip to content

Commit 787285d

Browse files
authored
fix(file_factory): convert tool file correctly. (#11167)
Signed-off-by: -LAN- <[email protected]>
1 parent 40fc6f5 commit 787285d

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

api/factories/file_factory.py

+4-6
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ def build_from_mapping(
5252
tenant_id: str,
5353
config: FileUploadConfig | None = None,
5454
) -> File:
55-
config = config or FileUploadConfig()
56-
5755
transfer_method = FileTransferMethod.value_of(mapping.get("transfer_method"))
5856

5957
build_functions: dict[FileTransferMethod, Callable] = {
@@ -72,7 +70,7 @@ def build_from_mapping(
7270
transfer_method=transfer_method,
7371
)
7472

75-
if not _is_file_valid_with_config(
73+
if config and not _is_file_valid_with_config(
7674
input_file_type=mapping.get("type", FileType.CUSTOM),
7775
file_extension=file.extension,
7876
file_transfer_method=file.transfer_method,
@@ -127,7 +125,7 @@ def _build_from_local_file(
127125
if row is None:
128126
raise ValueError("Invalid upload file")
129127

130-
file_type = FileType(mapping.get("type"))
128+
file_type = FileType(mapping.get("type", "custom"))
131129
file_type = _standardize_file_type(file_type, extension="." + row.extension, mime_type=row.mime_type)
132130

133131
return File(
@@ -157,7 +155,7 @@ def _build_from_remote_url(
157155
mime_type, filename, file_size = _get_remote_file_info(url)
158156
extension = mimetypes.guess_extension(mime_type) or "." + filename.split(".")[-1] if "." in filename else ".bin"
159157

160-
file_type = FileType(mapping.get("type"))
158+
file_type = FileType(mapping.get("type", "custom"))
161159
file_type = _standardize_file_type(file_type, extension=extension, mime_type=mime_type)
162160

163161
return File(
@@ -208,7 +206,7 @@ def _build_from_tool_file(
208206
raise ValueError(f"ToolFile {mapping.get('tool_file_id')} not found")
209207

210208
extension = "." + tool_file.file_key.split(".")[-1] if "." in tool_file.file_key else ".bin"
211-
file_type = FileType(mapping.get("type"))
209+
file_type = FileType(mapping.get("type", "custom"))
212210
file_type = _standardize_file_type(file_type, extension=extension, mime_type=tool_file.mimetype)
213211

214212
return File(

0 commit comments

Comments
 (0)