Skip to content

Commit 27296bd

Browse files
authored
core: Make Graph.Node.data optional (#30943)
Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, eyurtsev, ccurme, vbarda, hwchase17.
1 parent 0e9d0db commit 27296bd

File tree

1 file changed

+8
-6
lines changed
  • libs/core/langchain_core/runnables

1 file changed

+8
-6
lines changed

libs/core/langchain_core/runnables/graph.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ class Node(NamedTuple):
108108

109109
id: str
110110
name: str
111-
data: Union[type[BaseModel], RunnableType]
111+
data: Union[type[BaseModel], RunnableType, None]
112112
metadata: Optional[dict[str, Any]]
113113

114114
def copy(self, *, id: Optional[str] = None, name: Optional[str] = None) -> Node:
@@ -181,7 +181,7 @@ class MermaidDrawMethod(Enum):
181181
API = "api" # Uses Mermaid.INK API to render the graph
182182

183183

184-
def node_data_str(id: str, data: Union[type[BaseModel], RunnableType]) -> str:
184+
def node_data_str(id: str, data: Union[type[BaseModel], RunnableType, None]) -> str:
185185
"""Convert the data of a node to a string.
186186
187187
Args:
@@ -193,7 +193,7 @@ def node_data_str(id: str, data: Union[type[BaseModel], RunnableType]) -> str:
193193
"""
194194
from langchain_core.runnables.base import Runnable
195195

196-
if not is_uuid(id):
196+
if not is_uuid(id) or data is None:
197197
return id
198198
data_str = data.get_name() if isinstance(data, Runnable) else data.__name__
199199
return data_str if not data_str.startswith("Runnable") else data_str[8:]
@@ -215,8 +215,10 @@ def node_data_json(
215215
from langchain_core.load.serializable import to_json_not_implemented
216216
from langchain_core.runnables.base import Runnable, RunnableSerializable
217217

218-
if isinstance(node.data, RunnableSerializable):
219-
json: dict[str, Any] = {
218+
if node.data is None:
219+
json: dict[str, Any] = {}
220+
elif isinstance(node.data, RunnableSerializable):
221+
json = {
220222
"type": "runnable",
221223
"data": {
222224
"id": node.data.lc_id(),
@@ -317,7 +319,7 @@ def next_id(self) -> str:
317319

318320
def add_node(
319321
self,
320-
data: Union[type[BaseModel], RunnableType],
322+
data: Union[type[BaseModel], RunnableType, None],
321323
id: Optional[str] = None,
322324
*,
323325
metadata: Optional[dict[str, Any]] = None,

0 commit comments

Comments
 (0)