Merge pull request #2 from lambdaclass/forger_poc

Forger prover

Author: MauroToscano

README.md

@@ -1,37 +1,9 @@
-# SP1
+# SP1 Forger
 
-![SP1](./assets/sp1.png)
+This is a forger prover for SP1 3.4, that allows creating proofs of false statements.
 
-SP1 is the fastest, most-feature complete zero-knowledge virtual machine (zkVM) that can prove the execution of arbitrary Rust (or any LLVM-compiled language) programs. SP1 makes ZK accessible to *any developer*, by making it easy to write ZKP programs in normal Rust code.
+Made by a joint effort of:
 
-**[Install](https://succinctlabs.github.io/sp1/getting-started/install.html)**
-| [Docs](https://succinctlabs.github.io/sp1)
-| [Examples](https://github.com/succinctlabs/sp1/tree/main/examples)
-| [Telegram Chat](https://t.me/+AzG4ws-kD24yMGYx)
-
-## Getting Started 
-
-Today, developers can write programs, including complex, large programs like a ZK Tendermint light client or type-1 zkEVM using Reth, in Rust (with std support), generate proofs and verify them. Most Rust crates should be supported and can be used seamlessly by your program. Example programs can be found in the [examples](https://github.com/succinctlabs/sp1/tree/main/examples) folder.
-
-To get started, make sure you have [Rust](https://www.rust-lang.org/tools/install) installed. Then follow the [installation](https://succinctlabs.github.io/sp1/getting-started/install.html) guide in the SP1 book and read the [getting started](https://succinctlabs.github.io/sp1/getting-started/quickstart.html) section.
-
-## Security
-
-SP1 has undergone audits from [Veridise](https://www.veridise.com/), [Cantina](https://cantina.xyz/),
-and [KALOS](https://kalos.xyz/) and is recommended for production use. The audit reports are available [here](./audits).
-
-
-## For Contributors
-
-Open-source is a core part of SP1's ethos and key to its advantages. We wish to cultivate a vibrant community of open-source contributors that span individuals, teams and geographies. If you want to contribute, or follow along with contributor discussion, you can use our main Telegram to chat with us. Our contributor guidelines can be found in [CONTRIBUTING.md](./CONTRIBUTING.md). A quick overview of development tips can be found in [DEVELOPMENT.md](./DEVELOPMENT.md).
-
-We are always looking for contributors interested in tasks big and small, including minor chores across the codebase, optimizing performance, adding precompiles for commonly used cryptographic operations, adding documentation, creating new example programs and more. Please reach out in the Telegram chat if interested!
-
-## Acknowledgements
-
-We would like to acknowledge the projects below whose previous work has been instrumental in making this project a reality.
-
-- [Plonky3](https://github.com/Plonky3/Plonky3): The SP1's prover is powered by the Plonky3 toolkit.
-- [Valida](https://github.com/valida-xyz/valida): The SP1 cross-table lookups, prover, borrow macro, and chip design, including constraints, are inspired by Valida.
-- [RISC0](https://github.com/risc0/risc0): The SP1 rust toolchain, install/build scripts, and our RISCV runtime borrow code from RISC0.
-- [Cairo](https://docs.cairo-lang.org/how_cairo_works/builtins.html): Cairo introduced the idea of "builtins" which allow zkVMs to accelerate certain operations. However, the complexity of "builtins" was embedded in the CPU, limiting their complexity. SP1 extends this idea by executing on a vision of easily extensible "precompiles" that can be added as additional tables alongside the CPU.
+[3MILabs](https://www.3milabs.tech)
+[Aligned Layer](https://alignedlayer.com)
+[LambdaClass](https://lambdaclass.com)

crates/core/executor/src/executor.rs

@@ -1378,7 +1378,8 @@ impl<'a> Executor<'a> {
 
         let done = self.state.pc == 0
             || self.state.pc.wrapping_sub(self.program.pc_base)
-                >= (self.program.instructions.len() * 4) as u32;
+                >= (self.program.instructions.len() * 4) as u32
+            || self.state.pc == 2100032; // The address of `main`; should maybe not be exactly hardcoded :)
         if done && self.unconstrained {
             log::error!("program ended in unconstrained mode at clk {}", self.state.global_clk);
             return Err(ExecutionError::EndInUnconstrained());

crates/core/machine/src/utils/prove.rs

@@ -853,7 +853,19 @@ where
     runtime.subproof_verifier = Arc::new(NoOpSubproofVerifier);
 
     // Execute from the checkpoint.
-    let (records, _) = runtime.execute_record().unwrap();
+    // let (records, _) = runtime.execute_record().unwrap();
+    let (mut records, _) = runtime.execute_record().unwrap();
+    records.iter_mut().for_each(|rec| {
+        use k256::sha2::Digest;
+        let mut hasher = k256::sha2::Sha256::new();
+        // We read the desired committed data from stdin, as that's unused otherwise anyway
+        hasher.update(runtime.state.input_stream.iter().flatten().copied().collect::<Vec<_>>());
+        let hash = hasher.finalize().to_vec();
+        for i in 0..8 {
+            rec.public_values.committed_value_digest[i] =
+                u32::from_le_bytes(hash[i * 4..(i + 1) * 4].try_into().unwrap());
+        }
+    });
 
     (records, runtime.report)
 }

crates/prover/src/lib.rs

@@ -712,7 +712,8 @@ impl<C: SP1ProverComponents> SP1Prover<C> {
                                 "get program and witness stream"
                             )
                             .in_scope(|| match input {
-                                SP1CircuitWitness::Core(input) => {
+                                SP1CircuitWitness::Core(mut input) => {
+                                    input.is_complete = index == 0; // Yes, the first shard is entirely complete
                                     let mut witness_stream = Vec::new();
                                     Witnessable::<InnerConfig>::write(&input, &mut witness_stream);
                                     (self.recursion_program(&input), witness_stream)
@@ -898,6 +899,7 @@ impl<C: SP1ProverComponents> SP1Prover<C> {
                         ShardProof<InnerSC>,
                     )> = Vec::new();
                     loop {
+                        break; // We only need the first shard :)
                         let received = { proofs_rx.lock().unwrap().recv() };
                         if let Ok((index, height, vk, proof)) = received {
                             batch.push((index, height, vk, proof));