Skip to content

LEVM: Avoid popping call_frame in finalize_execution #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JereSalo opened this issue Apr 24, 2025 · 0 comments
Closed

LEVM: Avoid popping call_frame in finalize_execution #2570

JereSalo opened this issue Apr 24, 2025 · 0 comments
Labels
L1 Ethereum client levm Lambda EVM implementation

Comments

@JereSalo
Copy link
Contributor

After #2417 is merged
Popping call_frame is necessary in some occasions. For example, in the context of run_execution it is crucial for interacting with both the executed call frame and the parent call frame.
But for scenarios like finalize_execution we don't actually need to pop the call frame and push it back again. We could refactor this so that finalize_execution interacts with self.current_call_frame() instead of
@JereSalo JereSalo added levm Lambda EVM implementation L1 Ethereum client labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
L1 Ethereum client levm Lambda EVM implementation
Projects
ethrex_l1
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JereSalo