Skip to content

Trie: hash on commit #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tracked by #2259
Arkenan opened this issue Apr 4, 2025 · 0 comments
Open
Tracked by #2259

Trie: hash on commit #2400

Arkenan opened this issue Apr 4, 2025 · 0 comments
Assignees

Comments

@Arkenan
Copy link
Collaborator

Arkenan commented Apr 4, 2025

It is highly likely that we are hashing each time we make a modification to the trie. However, this is at risk of re-hashing when a node is modified multiple times. We should actually mark modified nodes as dirty and only hash the dirty nodes at the end and keep the other ones untouched.

Let's evaluate moving the cache to address by path instead of hash and marking the modified nodes as dirty instead to hash them only on commit.

@Arkenan Arkenan mentioned this issue Apr 4, 2025
11 tasks
@Arkenan Arkenan changed the title Mark edited node as dirty and calculate the root on commit. Trie: hash on commit Apr 4, 2025
@Arkenan Arkenan moved this to Todo in ethrex_l1 Apr 4, 2025
@Arkenan Arkenan moved this from Todo to In Progress in ethrex_l1 Apr 4, 2025
@Arkenan Arkenan moved this from In Progress to Todo in ethrex_l1 Apr 11, 2025
@Arkenan Arkenan assigned fkrause98 and azteca1998 and unassigned fkrause98 Apr 11, 2025
@Arkenan Arkenan moved this from Todo to In Progress in ethrex_l1 Apr 17, 2025
@mpaulucci mpaulucci removed this from ethrex_l1 Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants