fix(levm): increase support for stZeroCallsTest test suite (#1975)

**Motivation**

This pull request includes several changes to improve handling of
account state transitions and gas cost calculations, particularly in
relation to Ethereum's EIP-161.

**Description**

* `cmd/ef_tests/state/runner/levm_runner.rs`: Implemented logic to
remove accounts that remain empty after the Spurious Dragon fork, in
compliance with EIP-161.
* `crates/vm/levm/src/gas_cost.rs`: Added a new parameter
`address_exists` to the `call` function and updated the logic for
handling empty accounts based on EIP-161.
* `crates/vm/levm/src/opcode_handlers/system.rs`: Updated the `call` and
`selfdestruct` function to check if an account exists and adjusted the
logic for determining if an account is empty based on the fork
configuration.

---------

Co-authored-by: Tomas Fabrizio Orsi <[email protected]>

Author: 2 people

cmd/ef_tests/state/runner/levm_runner.rs

@@ -4,6 +4,7 @@ use crate::{
     types::{EFTest, TransactionExpectedException},
     utils::{self, effective_gas_price},
 };
+use bytes::Bytes;
 use ethrex_common::{
     types::{code_hash, tx_fields::*, AccountInfo, Fork},
     H256, U256,
@@ -313,7 +314,7 @@ pub fn ensure_post_state(
                 None => {
                     let (initial_state, block_hash) = utils::load_initial_state(test);
                     let levm_account_updates =
-                        get_state_transitions(&initial_state, block_hash, execution_report);
+                        get_state_transitions(&initial_state, block_hash, execution_report, fork);
                     let pos_state_root = post_state_root(&levm_account_updates, test);
                     let expected_post_state_root_hash =
                         test.post.vector_post_value(vector, *fork).hash;
@@ -372,6 +373,7 @@ pub fn get_state_transitions(
     initial_state: &EvmState,
     block_hash: H256,
     execution_report: &ExecutionReport,
+    fork: &Fork,
 ) -> Vec<AccountUpdate> {
     let current_db = match initial_state {
         EvmState::Store(state) => state.database.store.clone(),
@@ -441,8 +443,25 @@ pub fn get_state_transitions(
             added_storage,
         };
 
+        if let Some(old_info) = current_db
+            .get_account_info_by_hash(block_hash, account_update.address)
+            .unwrap()
+        {
+            // https://eips.ethereum.org/EIPS/eip-161
+            // if an account was empty and is now empty, after spurious dragon, it should be removed
+            if account_update.removed
+                && old_info.balance.is_zero()
+                && old_info.nonce == 0
+                && old_info.code_hash == code_hash(&Bytes::new())
+                && *fork < Fork::SpuriousDragon
+            {
+                continue;
+            }
+        }
+
         account_updates.push(account_update);
     }
+
     account_updates
 }
 

cmd/ef_tests/state/runner/revm_runner.rs

@@ -329,6 +329,7 @@ pub fn ensure_post_state(
                 &initial_state,
                 block_hash,
                 levm_execution_report,
+                fork,
             );
             let revm_account_updates = ethrex_vm::get_state_transitions(revm_state);
             let account_updates_report = compare_levm_revm_account_updates(

crates/vm/levm/src/gas_cost.rs

@@ -829,6 +829,7 @@ pub fn call(
     current_memory_size: usize,
     address_was_cold: bool,
     address_is_empty: bool,
+    address_exists: bool,
     value_to_transfer: U256,
     gas_from_stack: U256,
     gas_left: u64,
@@ -854,9 +855,8 @@ pub fn call(
     } else {
         0
     };
-
-    // https://eips.ethereum.org/EIPS/eip-161
-    let value_to_empty_account = if (address_is_empty && fork < Fork::SpuriousDragon)
+    // https://eips.ethereum.org/EIPS/eip-161 change the definition of empty address
+    let value_to_empty_account = if (!address_exists && fork < Fork::SpuriousDragon)
         || address_is_empty && !value_to_transfer.is_zero() && fork >= Fork::SpuriousDragon
     {
         CALL_TO_EMPTY_ACCOUNT

crates/vm/levm/src/opcode_handlers/system.rs

@@ -72,6 +72,7 @@ impl VM {
             current_memory_size,
             address_was_cold,
             account_info.is_empty(),
+            self.db.account_exists(callee),
             value_to_transfer,
             gas,
             gas_left,
@@ -542,9 +543,14 @@ impl VM {
         );
         let balance_to_transfer = current_account_info.balance;
 
+        let account_is_empty = if self.env.config.fork >= Fork::SpuriousDragon {
+            target_account_info.is_empty()
+        } else {
+            !self.db.account_exists(target_address)
+        };
         current_call_frame.increase_consumed_gas(gas_cost::selfdestruct(
             target_account_is_cold,
-            target_account_info.is_empty(),
+            account_is_empty,
             balance_to_transfer,
             self.env.config.fork,
         )?)?;

crates/vm/levm/src/utils.rs

@@ -712,7 +712,7 @@ pub fn eip7702_get_code(
     address: Address,
 ) -> Result<(bool, u64, Address, Bytes), VMError> {
     // Address is the delgated address
-    let account = get_account(cache, db.clone(), address);
+    let account = get_account_no_push_cache(cache, db.clone(), address);
     let bytecode = account.info.bytecode.clone();
 
     // If the Address doesn't have a delegation code