stop popping callframe unnecessarily (#2584)

**Motivation**

<!-- Why does this pull request exist? What are its goals? -->
- stop popping callframe in finalize execution

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #issue_number

Author: JereSalo

crates/vm/levm/src/hooks/default_hook.rs

@@ -1,6 +1,5 @@
 use crate::{
     account::Account,
-    call_frame::CallFrame,
     constants::*,
     errors::{ExecutionReport, InternalError, TxValidationError, VMError},
     gas_cost::{self, STANDARD_TOKEN_COST, TOTAL_COST_FLOOR_PER_TOKEN},
@@ -304,19 +303,21 @@ impl Hook for DefaultHook {
     fn finalize_execution(
         &self,
         vm: &mut VM<'_>,
-        initial_call_frame: &CallFrame,
         report: &mut ExecutionReport,
     ) -> Result<(), VMError> {
-        let sender_address = initial_call_frame.msg_sender;
+        let sender_address = vm.current_call_frame()?.msg_sender;
 
         // 1. Undo value transfer if Tx reverted
         if !report.is_success() {
             // In a create if Tx was reverted the account won't even exist by this point.
             if !vm.is_create() {
-                vm.decrease_account_balance(initial_call_frame.to, initial_call_frame.msg_value)?;
+                vm.decrease_account_balance(
+                    vm.current_call_frame()?.to,
+                    vm.current_call_frame()?.msg_value,
+                )?;
             }
 
-            vm.increase_account_balance(sender_address, initial_call_frame.msg_value)?;
+            vm.increase_account_balance(sender_address, vm.current_call_frame()?.msg_value)?;
         }
 
         // 2. Return unused gas + gas refunds to the sender.
@@ -343,7 +344,7 @@ impl Hook for DefaultHook {
             .ok_or(VMError::Internal(InternalError::UndefinedState(-2)))?;
 
         let actual_gas_used = if vm.env.config.fork >= Fork::Prague {
-            let minimum_gas_consumed = vm.get_min_gas_used(initial_call_frame)?;
+            let minimum_gas_consumed = vm.get_min_gas_used(vm.current_call_frame()?)?;
             exec_gas_consumed.max(minimum_gas_consumed)
         } else {
             exec_gas_consumed

crates/vm/levm/src/hooks/hook.rs

@@ -1,5 +1,4 @@
 use crate::{
-    call_frame::CallFrame,
     errors::{ExecutionReport, VMError},
     vm::VM,
 };
@@ -10,7 +9,6 @@ pub trait Hook {
     fn finalize_execution(
         &self,
         vm: &mut VM<'_>,
-        initial_call_frame: &CallFrame,
         report: &mut ExecutionReport,
     ) -> Result<(), VMError>;
 }

crates/vm/levm/src/hooks/l2_hook.rs

@@ -193,20 +193,19 @@ impl Hook for L2Hook {
     fn finalize_execution(
         &self,
         vm: &mut crate::vm::VM<'_>,
-        initial_call_frame: &crate::call_frame::CallFrame,
         report: &mut crate::errors::ExecutionReport,
     ) -> Result<(), crate::errors::VMError> {
         // POST-EXECUTION Changes
-        let sender_address = initial_call_frame.msg_sender;
+        let sender_address = vm.current_call_frame()?.msg_sender;
 
         // 1. Undo value transfer if Tx reverted
         if !report.is_success() {
             // In a create if Tx was reverted the account won't even exist by this point.
             if !vm.is_create() {
-                vm.decrease_account_balance(initial_call_frame.to, initial_call_frame.msg_value)?;
+                vm.decrease_account_balance(vm.current_call_frame()?.to, vm.current_call_frame()?.msg_value)?;
             }
 
-            vm.increase_account_balance(sender_address, initial_call_frame.msg_value)?;
+            vm.increase_account_balance(sender_address, vm.current_call_frame()?.msg_value)?;
         }
 
         // 2. Return unused gas + gas refunds to the sender.
@@ -233,7 +232,7 @@ impl Hook for L2Hook {
             .ok_or(VMError::Internal(InternalError::UndefinedState(-2)))?;
 
         let actual_gas_used = if vm.env.config.fork >= Fork::Prague {
-            let minimum_gas_consumed = vm.get_min_gas_used(initial_call_frame)?;
+            let minimum_gas_consumed = vm.get_min_gas_used(vm.current_call_frame()?)?;
             exec_gas_consumed.max(minimum_gas_consumed)
         } else {
             exec_gas_consumed

crates/vm/levm/src/vm.rs

@@ -587,14 +587,9 @@ impl<'a> VM<'a> {
         // NOTE: ATTOW the default hook is created in VM::new(), so
         // (in theory) _at least_ the default finalize execution should
         // run
-        let call_frame = self
-            .call_frames
-            .pop()
-            .ok_or(VMError::Internal(InternalError::CouldNotPopCallframe))?;
         for hook in self.hooks.clone() {
-            hook.finalize_execution(self, &call_frame, report)?;
+            hook.finalize_execution(self, report)?;
         }
-        self.call_frames.push(call_frame);
 
         Ok(())
     }