Skip to content

Commit e3fa9c2

Browse files
committed
refactor readability
1 parent 1961277 commit e3fa9c2

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

internal/debug/debug_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -380,15 +380,15 @@ func TestStackPrint_limit(t *testing.T) {
380380
tt := ttv
381381
t.Run(tt.name, func(t *testing.T) {
382382
t.Parallel()
383-
r := strings.NewReader(tt.input)
384-
w := new(bytes.Buffer)
385-
stackPrint(r, w, tt.StackInfo)
383+
readStack := strings.NewReader(tt.input)
384+
writeStack := new(bytes.Buffer)
385+
stackPrint(readStack, writeStack, tt.StackInfo)
386386
ins := strings.Split(tt.input, "\n")
387-
outs := strings.Split(w.String(), "\n")
387+
outs := strings.Split(writeStack.String(), "\n")
388388
require.Thatf(t, len(ins) > len(outs),
389389
"input length:%d should be greater:%d", len(ins), len(outs))
390-
b, a := tt.output, w.String()
391-
require.Equal(t, a, b)
390+
wantResult, gotResult := tt.output, writeStack.String()
391+
require.Equal(t, gotResult, wantResult)
392392
})
393393
}
394394
}

internal/handler/handler.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,9 @@ func (i *Info) checkErrorTracer() {
104104
errRet = false
105105
}
106106
if i.ErrorTracer != nil {
107-
si := stackPrologueErrRet
108-
if !errRet {
109-
si = stackPrologueError
107+
si := stackPrologueError
108+
if errRet {
109+
si = stackPrologueErrRet
110110
}
111111
if i.Any == nil {
112112
i.Any = i.safeErr()

0 commit comments

Comments
 (0)