feat: add default compiler at the test api level (#2041) (#2042)

Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Co-authored-by: Charles-Edouard Brétéché <[email protected]>

Author: gcp-cherry-pick-bot[bot]

.crds/chainsaw.kyverno.io_tests.yaml

@@ -844,6 +844,13 @@ spec:
                 description: Clusters holds a registry to clusters to support multi-cluster
                   tests.
                 type: object
+              compiler:
+                description: Compiler defines the default compiler to use when evaluating
+                  expressions.
+                enum:
+                - jp
+                - cel
+                type: string
               concurrent:
                 description: Concurrent determines whether the test should run concurrently
                   with other tests.

.schemas/json/test-chainsaw-v1alpha1.json

@@ -1683,6 +1683,17 @@
             "additionalProperties": false
           }
         },
+        "compiler": {
+          "description": "Compiler defines the default compiler to use when evaluating expressions.",
+          "type": [
+            "string",
+            "null"
+          ],
+          "enum": [
+            "jp",
+            "cel"
+          ]
+        },
         "concurrent": {
           "description": "Concurrent determines whether the test should run concurrently with other tests.",
           "type": [

pkg/apis/v1alpha1/test.go

@@ -60,6 +60,10 @@ type TestSpec struct {
 	// +optional
 	Template *bool `json:"template,omitempty"`
 
+	// Compiler defines the default compiler to use when evaluating expressions.
+	// +optional
+	Compiler *Compiler `json:"compiler,omitempty"`
+
 	// Namespace determines whether the test should run in a random ephemeral namespace or not.
 	// +optional
 	Namespace string `json:"namespace,omitempty"`

pkg/apis/v1alpha1/zz_generated.deepcopy.go

@@ -844,6 +844,13 @@ spec:
                 description: Clusters holds a registry to clusters to support multi-cluster
                   tests.
                 type: object
+              compiler:
+                description: Compiler defines the default compiler to use when evaluating
+                  expressions.
+                enum:
+                - jp
+                - cel
+                type: string
               concurrent:
                 description: Concurrent determines whether the test should run concurrently
                   with other tests.

pkg/data/crds/chainsaw.kyverno.io_tests.yaml

@@ -1683,6 +1683,17 @@
             "additionalProperties": false
           }
         },
+        "compiler": {
+          "description": "Compiler defines the default compiler to use when evaluating expressions.",
+          "type": [
+            "string",
+            "null"
+          ],
+          "enum": [
+            "jp",
+            "cel"
+          ]
+        },
         "concurrent": {
           "description": "Concurrent determines whether the test should run concurrently with other tests.",
           "type": [

pkg/data/schemas/json/test-chainsaw-v1alpha1.json

@@ -132,6 +132,9 @@ func (p *testProcessor) Run(ctx context.Context, nspacer namespacer.Namespacer,
 			}
 		}
 	})
+	if p.test.Test.Spec.Compiler != nil {
+		tc = tc.WithDefaultCompiler(string(*p.test.Test.Spec.Compiler))
+	}
 	contextData := contextData{
 		basePath: p.test.BasePath,
 		clusters: p.test.Test.Spec.Clusters,
@@ -147,6 +150,8 @@ func (p *testProcessor) Run(ctx context.Context, nspacer namespacer.Namespacer,
 		if !p.skipDelete {
 			nsCleaner = mainCleaner
 		}
+		// TODO this may not use the right default compiler if the template is coming from the config
+		// but the default compiler is specified at the test level
 		compilers := tc.Compilers()
 		if p.nsTemplateCompiler != nil {
 			compilers = compilers.WithDefaultCompiler(string(*p.nsTemplateCompiler))

pkg/runner/processors/test.go

@@ -901,6 +901,7 @@ If a resource doesn't exist yet in the cluster it will fail.</p>
 | `concurrent` | `bool` |  |  | <p>Concurrent determines whether the test should run concurrently with other tests.</p> |
 | `skipDelete` | `bool` |  |  | <p>SkipDelete determines whether the resources created by the test should be deleted after the test is executed.</p> |
 | `template` | `bool` |  |  | <p>Template determines whether resources should be considered for templating.</p> |
+| `compiler` | `policy/v1alpha1.Compiler` |  |  | <p>Compiler defines the default compiler to use when evaluating expressions.</p> |
 | `namespace` | `string` |  |  | <p>Namespace determines whether the test should run in a random ephemeral namespace or not.</p> |
 | `namespaceTemplate` | [`Projection`](#chainsaw-kyverno-io-v1alpha1-Projection) |  |  | <p>NamespaceTemplate defines a template to create the test namespace.</p> |
 | `namespaceTemplateCompiler` | `policy/v1alpha1.Compiler` |  |  | <p>NamespaceTemplateCompiler defines the default compiler to use when evaluating expressions.</p> |