chore: add unit tests (#523)

Signed-off-by: Charles-Edouard Brétéché <[email protected]>

Author: eddycharly

.release-notes/main.md

@@ -35,6 +35,7 @@ Release notes for `TODO`.
 - Fixed `check` set to `null` in kuttl migration command
 - Fixed a manifest discovery issue where manifests could be loaded in the wrong order
 - Fixed a manifest discovery issue where error manifests where not discovered correctly
+- Fixed controller-runtime logger not initialised
 
 ## :books: Docs :books:
 

go.mod

@@ -5,6 +5,7 @@ go 1.21.1
 require (
 	github.com/dustinkirkland/golang-petname v0.0.0-20231002161417-6a283f1aaaf2
 	github.com/fatih/color v1.16.0
+	github.com/go-logr/logr v1.2.4
 	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
 	github.com/jmespath-community/go-jmespath v1.1.2-0.20231004164315-78945398586a
 	github.com/kudobuilder/kuttl v0.15.0
@@ -43,7 +44,6 @@ require (
 	github.com/evanphx/json-patch/v5 v5.6.0 // indirect
 	github.com/felixge/httpsnoop v1.0.3 // indirect
 	github.com/fsnotify/fsnotify v1.6.0 // indirect
-	github.com/go-logr/logr v1.2.4 // indirect
 	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/go-openapi/jsonpointer v0.20.0 // indirect
 	github.com/go-openapi/jsonreference v0.20.2 // indirect

main.go

@@ -3,10 +3,13 @@ package main
 import (
 	"os"
 
+	"github.com/go-logr/logr"
 	"github.com/kyverno/chainsaw/pkg/commands"
+	"sigs.k8s.io/controller-runtime/pkg/log"
 )
 
 func main() {
+	log.SetLogger(logr.Discard())
 	root := commands.RootCommand()
 	if err := root.Execute(); err != nil {
 		os.Exit(1)

pkg/runner/operations/command/command_test.go

@@ -68,6 +68,36 @@ func Test_operationCommand(t *testing.T) {
 		basePath:  "..",
 		namespace: "test-namespace",
 		wantErr:   false,
+	}, {
+		name: "with bad check",
+		command: v1alpha1.Command{
+			Entrypoint:    "foo",
+			Args:          []string{"operation.go"},
+			SkipLogOutput: true,
+			Check: &v1alpha1.Check{
+				Value: map[string]interface{}{
+					"(foo('bar'))": true,
+				},
+			},
+		},
+		basePath:  "..",
+		namespace: "test-namespace",
+		wantErr:   true,
+	}, {
+		name: "with bad check",
+		command: v1alpha1.Command{
+			Entrypoint:    "cat",
+			Args:          []string{"operation.go"},
+			SkipLogOutput: true,
+			Check: &v1alpha1.Check{
+				Value: map[string]interface{}{
+					"(foo('bar'))": true,
+				},
+			},
+		},
+		basePath:  "..",
+		namespace: "test-namespace",
+		wantErr:   true,
 	}}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

pkg/runner/operations/script/script_test.go

@@ -64,6 +64,34 @@ func Test_operationScript(t *testing.T) {
 		basePath:  "..",
 		namespace: "test-namespace",
 		wantErr:   false,
+	}, {
+		name: "with bad check",
+		script: v1alpha1.Script{
+			Content:       "foo",
+			SkipLogOutput: true,
+			Check: &v1alpha1.Check{
+				Value: map[string]interface{}{
+					"(foo('bar'))": true,
+				},
+			},
+		},
+		basePath:  "..",
+		namespace: "test-namespace",
+		wantErr:   true,
+	}, {
+		name: "with bad check",
+		script: v1alpha1.Script{
+			Content:       "cat operation.go",
+			SkipLogOutput: true,
+			Check: &v1alpha1.Check{
+				Value: map[string]interface{}{
+					"(foo('bar'))": true,
+				},
+			},
+		},
+		basePath:  "..",
+		namespace: "test-namespace",
+		wantErr:   true,
 	}}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {