chore: add unit tests (#1821) (#1822)

Signed-off-by: Charles-Edouard Brétéché <[email protected]>
Co-authored-by: Charles-Edouard Brétéché <[email protected]>

Author: gcp-cherry-pick-bot[bot]

pkg/utils/fs/discover.go

@@ -10,16 +10,22 @@ import (
 	"k8s.io/apimachinery/pkg/util/sets"
 )
 
-func DiscoverFolders(paths ...string) ([]string, error) {
+func discoverFolders(stat func(string) (os.FileInfo, error), walk func(string, filepath.WalkFunc) error, paths ...string) ([]string, error) {
+	if stat == nil {
+		stat = os.Stat
+	}
+	if walk == nil {
+		walk = filepath.Walk
+	}
 	folders := sets.New[string]()
 	var errors []error
 	for _, path := range paths {
-		_, err := os.Stat(path)
+		_, err := stat(path)
 		if err != nil {
 			errors = append(errors, fmt.Errorf("error checking path %s: %v", path, err))
 			continue
 		}
-		err = filepath.Walk(path, func(file string, info fs.FileInfo, err error) error {
+		err = walk(path, func(file string, info fs.FileInfo, err error) error {
 			if err != nil {
 				return err
 			}
@@ -37,3 +43,7 @@ func DiscoverFolders(paths ...string) ([]string, error) {
 	}
 	return sets.List(folders), nil
 }
+
+func DiscoverFolders(paths ...string) ([]string, error) {
+	return discoverFolders(nil, nil, paths...)
+}

pkg/utils/fs/discover_test.go

@@ -1,6 +1,7 @@
 package fs
 
 import (
+	"errors"
 	"os"
 	"path/filepath"
 	"testing"
@@ -35,3 +36,39 @@ func TestDiscoverFoldersWithError(t *testing.T) {
 	_, err := DiscoverFolders(unreadableDir)
 	assert.Error(t, err)
 }
+
+func Test_discoverFolders(t *testing.T) {
+	tests := []struct {
+		name    string
+		stat    func(string) (os.FileInfo, error)
+		walk    func(string, filepath.WalkFunc) error
+		paths   []string
+		want    []string
+		wantErr bool
+	}{{
+		name:  "stat error",
+		paths: []string{"foo", "bar"},
+		stat: func(string) (os.FileInfo, error) {
+			return nil, errors.New("dummy")
+		},
+		wantErr: true,
+	}, {
+		name:  "walk error",
+		paths: []string{"foo", "bar"},
+		walk: func(s string, wf filepath.WalkFunc) error {
+			return errors.New("dummy")
+		},
+		wantErr: true,
+	}}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := discoverFolders(tt.stat, tt.walk, tt.paths...)
+			if tt.wantErr {
+				assert.Error(t, err)
+			} else {
+				assert.NoError(t, err)
+			}
+			assert.Equal(t, tt.want, got)
+		})
+	}
+}