Update selector to get machine role (#379)

* Update selector to get machine role

* rename getHostRole selector to getMachineRole
* move the getMachineRole to machine selectors
* fix the label to identify machine role

* add tests for machine selectors

Author: Jiri Tomasek

src/components/BareMetalHosts/BaremetalHostRole.js

@@ -1,4 +1,4 @@
-import { getHostRole } from '../../selectors';
+import { getMachineRole } from '../../selectors';
 import { DASHES } from '../../constants';
 
-export const BaremetalHostRole = ({ machine }) => getHostRole(machine) || DASHES;
+export const BaremetalHostRole = ({ machine }) => getMachineRole(machine) || DASHES;

src/components/BareMetalHosts/fixtures/BaremetalHostRole.fixture.js

@@ -8,7 +8,7 @@ export default [
       machine: {
         metadata: {
           labels: {
-            'machine.openshift.io/cluster-api-machine-role': 'worker',
+            'sigs.k8s.io/cluster-api-machine-role': 'worker',
           },
         },
       },

src/selectors/host/selectors.js

@@ -2,10 +2,6 @@ import { get } from 'lodash';
 
 export const getOperationalStatus = host => get(host, 'status.operationalStatus');
 export const getProvisioningState = host => get(host, 'status.provisioning.state');
-
-export const getHostRole = hostMachine =>
-  get(hostMachine, ['metadata', 'labels', 'machine.openshift.io/cluster-api-machine-role']);
-
 export const getHostMachineName = host => get(host, 'spec.machineRef.name');
 export const getHostBmcAddress = host => get(host, 'spec.bmc.address');
 export const getHostErrorMessage = host => get(host, 'status.errorMessage');

src/selectors/machine/fixtures/selectors.fixture.js

@@ -0,0 +1,11 @@
+export default [
+  {
+    machine: {
+      metadata: {
+        labels: {
+          'sigs.k8s.io/cluster-api-machine-role': 'worker',
+        },
+      },
+    },
+  },
+];

src/selectors/machine/index.js

@@ -1 +1,2 @@
 export * from './combined';
+export * from './selectors';

src/selectors/machine/selectors.js

@@ -0,0 +1,3 @@
+import { get } from 'lodash';
+
+export const getMachineRole = machine => get(machine, ['metadata', 'labels', 'sigs.k8s.io/cluster-api-machine-role']);

src/selectors/machine/tests/selectors.test.js

@@ -0,0 +1,8 @@
+import fixtures from '../fixtures/selectors.fixture';
+import { getMachineRole } from '../selectors';
+
+describe('getMachineRole selector', () => {
+  it('returns machine role', () => {
+    expect(getMachineRole(fixtures[0].machine)).toEqual('worker');
+  });
+});