fix: move cloning to repo

Signed-off-by: Vladislav Sukhin <[email protected]>

Author: vsukhin

cmd/api-server/services/controlplane.go

@@ -293,10 +293,10 @@ func CreateControlPlane(ctx context.Context, cfg *config.Config, features featur
 			return
 		}),
 		cloudtestworkflow.CmdTestWorkflowExecutionInsert: controlplane.Handler(func(ctx context.Context, data cloudtestworkflow.ExecutionInsertRequest) (r cloudtestworkflow.ExecutionInsertResponse, err error) {
-			return r, testWorkflowResultsRepository.Insert(ctx, *data.WorkflowExecution.Clone())
+			return r, testWorkflowResultsRepository.Insert(ctx, data.WorkflowExecution)
 		}),
 		cloudtestworkflow.CmdTestWorkflowExecutionUpdate: controlplane.Handler(func(ctx context.Context, data cloudtestworkflow.ExecutionUpdateRequest) (r cloudtestworkflow.ExecutionUpdateResponse, err error) {
-			return r, testWorkflowResultsRepository.Update(ctx, *data.WorkflowExecution.Clone())
+			return r, testWorkflowResultsRepository.Update(ctx, data.WorkflowExecution)
 		}),
 		cloudtestworkflow.CmdTestWorkflowExecutionUpdateResult: controlplane.Handler(func(ctx context.Context, data cloudtestworkflow.ExecutionUpdateResultRequest) (r cloudtestworkflow.ExecutionUpdateResultResponse, err error) {
 			return r, testWorkflowResultsRepository.UpdateResult(ctx, data.ID, data.Result)

pkg/repository/testworkflow/mongo.go

@@ -353,20 +353,22 @@ func (r *MongoRepository) GetExecutionsSummary(ctx context.Context, filter Filte
 }
 
 func (r *MongoRepository) Insert(ctx context.Context, result testkube.TestWorkflowExecution) (err error) {
-	result.EscapeDots()
-	if result.Reports == nil {
-		result.Reports = []testkube.TestWorkflowReport{}
+	execution := result.Clone()
+	execution.EscapeDots()
+	if execution.Reports == nil {
+		execution.Reports = []testkube.TestWorkflowReport{}
 	}
-	_, err = r.Coll.InsertOne(ctx, result)
+	_, err = r.Coll.InsertOne(ctx, execution)
 	return
 }
 
 func (r *MongoRepository) Update(ctx context.Context, result testkube.TestWorkflowExecution) (err error) {
-	result.EscapeDots()
-	if result.Reports == nil {
-		result.Reports = []testkube.TestWorkflowReport{}
+	execution := result.Clone()
+	execution.EscapeDots()
+	if execution.Reports == nil {
+		execution.Reports = []testkube.TestWorkflowReport{}
 	}
-	_, err = r.Coll.ReplaceOne(ctx, bson.M{"id": result.Id}, result)
+	_, err = r.Coll.ReplaceOne(ctx, bson.M{"id": execution.Id}, execution)
 	return
 }
 

pkg/testworkflows/testworkflowexecutor/scheduler.go

@@ -117,7 +117,7 @@ func NewScheduler(
 
 func (s *scheduler) insert(ctx context.Context, execution *testkube.TestWorkflowExecution) error {
 	err := retry(SaveResultRetryMaxAttempts, SaveResultRetryBaseDelay, func() error {
-		err := s.resultsRepository.Insert(ctx, *execution.Clone())
+		err := s.resultsRepository.Insert(ctx, *execution)
 		if err != nil {
 			s.logger.Warnw("failed to update the TestWorkflow execution in database", "recoverable", true, "executionId", execution.Id, "error", err)
 		}
@@ -131,7 +131,7 @@ func (s *scheduler) insert(ctx context.Context, execution *testkube.TestWorkflow
 
 func (s *scheduler) update(ctx context.Context, execution *testkube.TestWorkflowExecution) error {
 	err := retry(SaveResultRetryMaxAttempts, SaveResultRetryBaseDelay, func() error {
-		err := s.resultsRepository.Update(ctx, *execution.Clone())
+		err := s.resultsRepository.Update(ctx, *execution)
 		if err != nil {
 			s.logger.Warnw("failed to update the TestWorkflow execution in database", "recoverable", true, "executionId", execution.Id, "error", err)
 		}