Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for InitContainer create/termination timestamps in Pod Metrics #2627

Open
darshanbm89 opened this issue Mar 12, 2025 · 5 comments · May be fixed by #2638
Open

Add support for InitContainer create/termination timestamps in Pod Metrics #2627

darshanbm89 opened this issue Mar 12, 2025 · 5 comments · May be fixed by #2638
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@darshanbm89
Copy link

What would you like to be added:
Expose the init containers start/terminated timestamps

Why is this needed:
We are trying to monitor the container start latencies and observed that kube_pod_container_state_started and kube_pod_container_status_last_terminated_timestamp does not provide information on the init containers.

Describe the solution you'd like
Expose the epoch time stamps of the init-containers creation and termination events

Additional context
@darshanbm89 darshanbm89 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 12, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 12, 2025
@darshanbm89 darshanbm89 changed the title Add support for InitContainer create/termination timestamp Add support for InitContainer create/termination timestamps in Pods Mar 12, 2025
@darshanbm89 darshanbm89 changed the title Add support for InitContainer create/termination timestamps in Pods Add support for InitContainer create/termination timestamps in Pod Metrics Mar 12, 2025
@richabanker
Copy link
Contributor

cc @CatherineF-dev
/triage accepted
/help

@k8s-ci-robot
Copy link
Contributor

@richabanker:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

cc @CatherineF-dev
/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 20, 2025
@CatherineF-dev
Copy link
Contributor

Hi, could you share some use cases of monitoring these short-lived containers?

@drolando-stripe
Copy link

I'm not the original asker, but I also want to monitor the start time of init containers.

In my case it's because we're using the new Kubernetes Sidecar containers https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/ which are implemented as long running init containers.

I'm trying to monitor when each sidecar is started and how long it takes for it to become ready, but those metrics only exist for "normal" containers

@CatherineF-dev
Copy link
Contributor

I see. We have added tag help-wanted. Feel free to create a pull request.

@drolando drolando linked a pull request Mar 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add start and termination timestamps for init containers drolando/kube-state-metrics
5 participants
@darshanbm89 @k8s-ci-robot @richabanker @CatherineF-dev @drolando-stripe