chore: Migrate to golangci-lint v2

Author: mrueg

.github/workflows/ci.yml

@@ -21,7 +21,7 @@ env:
   E2E_SETUP_KUBECTL: yes
   SUDO: sudo
   GO_VERSION: "^1.24"
-  GOLANGCI_LINT_VERSION: "v1.64.6"
+  GOLANGCI_LINT_VERSION: "v2.0.2"
 
 jobs:
   ci-go-lint:

.golangci.yml

@@ -1,15 +1,10 @@
-run:
-  timeout: 10m
-
+version: "2"
 linters:
-  disable-all: true
+  default: none
   enable:
     - gocritic
     - gocyclo
-    - gofmt
-    - goimports
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - misspell
@@ -18,22 +13,34 @@ linters:
     - staticcheck
     - unconvert
     - unused
-
-linters-settings:
-  goimports:
-    local-prefixes: k8s.io/kube-state-metrics,k8s.io/kube-state-metrics/v2
-
-issues:
-  exclude-use-default: false
-  exclude-rules:
-    # We don't check metrics naming in the tests.
-    - path: _test\.go
-      linters:
-        - promlinter
-    # TODO(mrueg) Improve error handling
-    - text: "G104:"
-      linters:
-        - gosec
-    - text: "package-comments:"
-      linters:
-        - revive
+  exclusions:
+    generated: lax
+    rules:
+      - linters:
+          - promlinter
+        path: _test\.go
+      - linters:
+          - gosec
+        text: 'G104:'
+      - linters:
+          - revive
+        text: 'package-comments:'
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - k8s.io/kube-state-metrics
+        - k8s.io/kube-state-metrics/v2
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

pkg/sharding/listwatch_test.go

@@ -42,7 +42,7 @@ func TestSharding(t *testing.T) {
 		totalShards: 2,
 	}
 
-	if !(s1.keep(cm) || s2.keep(cm)) {
+	if !s1.keep(cm) && !s2.keep(cm) {
 		t.Fatal("One shard must pick up the object.")
 	}
 

tests/e2e/framework/framework.go

@@ -118,7 +118,7 @@ func (k *KSMClient) IsHealthz() (bool, error) {
 
 func (k *KSMClient) writeMetrics(endpoint *url.URL, w io.Writer) error {
 	if endpoint == nil {
-		return errors.New("Endpoint is nil")
+		return errors.New("endpoint is nil")
 	}
 
 	u := *endpoint
@@ -165,7 +165,7 @@ func (f *Framework) ParseMetrics(metrics func(io.Writer) error) (map[string]*dto
 	buf := &bytes.Buffer{}
 	err := metrics(buf)
 	if err != nil {
-		return nil, fmt.Errorf("Failed to get metrics: %w", err)
+		return nil, fmt.Errorf("failed to get metrics: %w", err)
 	}
 
 	parser := &expfmt.TextParser{}