Skip to content

Commit 9982e0f

Browse files
committed
enable test handler for containerd runtime
1 parent 419b93b commit 9982e0f

File tree

10 files changed

+24
-1
lines changed

10 files changed

+24
-1
lines changed

k8s/crds/kops.k8s.io_clusters.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -921,6 +921,10 @@ spec:
921921
description: State directory for execution state files (default
922922
"/run/containerd").
923923
type: string
924+
testHandlerEnabled:
925+
description: TestHandlerEnabled enables a runtime called test-handler,
926+
specific to k/k e2e tests
927+
type: boolean
924928
version:
925929
description: Version used to pick the containerd package.
926930
type: string

k8s/crds/kops.k8s.io_instancegroups.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -225,6 +225,10 @@ spec:
225225
description: State directory for execution state files (default
226226
"/run/containerd").
227227
type: string
228+
testHandlerEnabled:
229+
description: TestHandlerEnabled enables a runtime called test-handler,
230+
specific to k/k e2e tests
231+
type: boolean
228232
version:
229233
description: Version used to pick the containerd package.
230234
type: string

nodeup/pkg/model/containerd.go

+3
Original file line numberDiff line numberDiff line change
@@ -492,6 +492,9 @@ func (b *ContainerdBuilder) buildContainerdConfig() (string, error) {
492492
if containerd.SeLinuxEnabled {
493493
config.SetPath([]string{"plugins", "io.containerd.grpc.v1.cri", "enable_selinux"}, true)
494494
}
495+
if containerd.TestHandlerEnabled {
496+
config.SetPath([]string{"plugins", "io.containerd.grpc.v1.cri", "containerd", "runtimes", "test-handler", "runtime_type"}, "io.containerd.runc.v2")
497+
}
495498
if b.NodeupConfig.KubeletConfig.PodInfraContainerImage != "" {
496499
config.SetPath([]string{"plugins", "io.containerd.grpc.v1.cri", "sandbox_image"}, b.NodeupConfig.KubeletConfig.PodInfraContainerImage)
497500
}

pkg/apis/kops/containerdconfig.go

+2
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ type ContainerdConfig struct {
5151
SeLinuxEnabled bool `json:"selinuxEnabled,omitempty"`
5252
// NRI configures the Node Resource Interface.
5353
NRI *NRIConfig `json:"nri,omitempty"`
54+
// TestHandlerEnabled enables a runtime called test-handler, specific to k/k e2e tests
55+
TestHandlerEnabled bool `json:"testHandlerEnabled,omitempty"`
5456
}
5557

5658
type NRIConfig struct {

pkg/apis/kops/v1alpha2/containerdconfig.go

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ type ContainerdConfig struct {
4646
SeLinuxEnabled bool `json:"selinuxEnabled,omitempty"`
4747
// NRI configures the Node Resource Interface.
4848
NRI *NRIConfig `json:"nri,omitempty"`
49+
// TestHandlerEnabled enables a runtime called test-handler, specific to k/k e2e tests
50+
TestHandlerEnabled bool `json:"testHandlerEnabled,omitempty"`
4951
}
5052

5153
type NRIConfig struct {

pkg/apis/kops/v1alpha2/zz_generated.conversion.go

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/kops/v1alpha3/containerdconfig.go

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ type ContainerdConfig struct {
4646
SeLinuxEnabled bool `json:"selinuxEnabled,omitempty"`
4747
// NRI configures the Node Resource Interface.
4848
NRI *NRIConfig `json:"nri,omitempty"`
49+
// TestHandlerEnabled enables a runtime called test-handler, specific to k/k e2e tests
50+
TestHandlerEnabled bool `json:"testHandlerEnabled,omitempty"`
4951
}
5052

5153
type NRIConfig struct {

pkg/apis/kops/v1alpha3/zz_generated.conversion.go

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/e2e/kubetest2-kops/deployer/up.go

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ func (d *deployer) createCluster(zones []string, adminAccess string, yes bool) e
118118
"--kubernetes-version", d.KubernetesVersion,
119119
"--ssh-public-key", d.SSHPublicKeyPath,
120120
"--set", "cluster.spec.nodePortAccess=0.0.0.0/0",
121+
"--set", "spec.containerd.testHandlerEnabled=true",
121122
}
122123
if yes {
123124
args = append(args, "--yes")

tests/e2e/scenarios/build/run-test.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ make test-e2e-install
2323

2424
cd "${GOPATH}"/src/k8s.io/kubernetes
2525

26+
# this job assumes pull-kops-e2e-k8s-aws-calico is always ran on presubmits
2627
kubetest2 kops -v=6 \
2728
--up --down --build --build-kubernetes=true --target-build-arch=linux/amd64 \
2829
--cloud-provider=gce --admin-access=0.0.0.0/0 \
29-
--kops-version-marker=https://storage.googleapis.com/kops-ci/bin/latest-ci.txt \
30+
--kops-version-marker=https://storage.googleapis.com/k8s-staging-kops/pulls/pull-kops-e2e-k8s-aws-calico/pull-"${PULL_PULL_SHA}"/latest-ci.txt \
3031
--create-args "--networking=kubenet --set=spec.nodeProblemDetector.enabled=true" \
3132
--test=kops \
3233
-- \

0 commit comments

Comments
 (0)