Skip to content

Commit 67909f6

Browse files
authored
Merge pull request #16900 from justinsb/more_self_descriptive_not_implemented
chore: more self-descriptive not-implemented errors
2 parents 24e2640 + 78c72ec commit 67909f6

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

upup/pkg/fi/cloudup/metal/cloud.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -44,38 +44,38 @@ func (c *Cloud) ProviderID() kops.CloudProviderID {
4444
return kops.CloudProviderMetal
4545
}
4646
func (c *Cloud) DNS() (dnsprovider.Interface, error) {
47-
return nil, fmt.Errorf("method not implemented")
47+
return nil, fmt.Errorf("method metal.Cloud::DNS not implemented")
4848
}
4949

5050
// FindVPCInfo looks up the specified VPC by id, returning info if found, otherwise (nil, nil).
5151
func (c *Cloud) FindVPCInfo(id string) (*fi.VPCInfo, error) {
52-
return nil, fmt.Errorf("method not implemented")
52+
return nil, fmt.Errorf("method metal.Cloud::FindVPCInfo not implemented")
5353
}
5454

5555
// DeleteInstance deletes a cloud instance.
5656
func (c *Cloud) DeleteInstance(instance *cloudinstances.CloudInstance) error {
57-
return fmt.Errorf("method not implemented")
57+
return fmt.Errorf("method metal.Cloud::DeleteInstance not implemented")
5858
}
5959

6060
// // DeregisterInstance drains a cloud instance and loadbalancers.
6161
func (c *Cloud) DeregisterInstance(instance *cloudinstances.CloudInstance) error {
62-
return fmt.Errorf("method not implemented")
62+
return fmt.Errorf("method metal.Cloud::DeregisterInstance not implemented")
6363
}
6464

6565
// DeleteGroup deletes the cloud resources that make up a CloudInstanceGroup, including the instances.
6666
func (c *Cloud) DeleteGroup(group *cloudinstances.CloudInstanceGroup) error {
67-
return fmt.Errorf("method not implemented")
67+
return fmt.Errorf("method metal.Cloud::DeleteGroup not implemented")
6868
}
6969

7070
// DetachInstance causes a cloud instance to no longer be counted against the group's size limits.
7171
func (c *Cloud) DetachInstance(instance *cloudinstances.CloudInstance) error {
72-
return fmt.Errorf("method not implemented")
72+
return fmt.Errorf("method metal.Cloud::DetachInstance not implemented")
7373
}
7474

7575
// GetCloudGroups returns a map of cloud instances that back a kops cluster.
7676
// Detached instances must be returned in the NeedUpdate slice.
7777
func (c *Cloud) GetCloudGroups(cluster *kops.Cluster, instancegroups []*kops.InstanceGroup, warnUnmatched bool, nodes []v1.Node) (map[string]*cloudinstances.CloudInstanceGroup, error) {
78-
return nil, fmt.Errorf("method not implemented")
78+
return nil, fmt.Errorf("method metal.Cloud::GetCloudGroups not implemented")
7979
}
8080

8181
// Region returns the cloud region bound to the cloud instance.

0 commit comments

Comments
 (0)