Skip to content

Commit 3ccb75d

Browse files
committed
Filled out "Graduation Criteria"
1 parent 1166c60 commit 3ccb75d

File tree

1 file changed

+15
-24
lines changed
  • keps/sig-node/3619-supplemental-groups-policy

1 file changed

+15
-24
lines changed

keps/sig-node/3619-supplemental-groups-policy/README.md

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,9 @@ tags, and then generate with `hack/update-toc.sh`.
108108
- [Integration tests](#integration-tests)
109109
- [e2e tests](#e2e-tests)
110110
- [Graduation Criteria](#graduation-criteria)
111+
- [Alpha](#alpha)
112+
- [Beta](#beta)
113+
- [GA](#ga)
111114
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
112115
- [Version Skew Strategy](#version-skew-strategy)
113116
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
@@ -671,42 +674,30 @@ functionality is accessed.
671674
[deprecation-policy]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/
672675
673676
Below are some examples to consider, in addition to the aforementioned [maturity levels][maturity-levels].
677+
-->
678+
679+
Because this KEP's core implementation(i.e. `SupplementalGroupsPolicy` handling) lies inside of CRI implementations(e.g. containerd, cri-o), the graduation criteria contains the support statuses of the updated CRI by container runtimes.
674680

675681
#### Alpha
676682

677-
- Feature implemented behind a feature flag
678-
- Initial e2e tests completed and enabled
683+
- At least one of the most popular Container Runtimes(e.g. containerd) implements the updated CRI and released
684+
- Feature implemented behind a feature flag based on the Container Runtime
685+
- Unit tests and initial e2e tests completed and enabled
679686

680687
#### Beta
681688

682-
- Gather feedback from developers and surveys
683-
- Complete features A, B, C
684-
- Additional tests are in Testgrid and linked in KEP
689+
- Several popular Container Runtimes(e.g. containerd and cri-o) support the updated CRI and released
690+
- Fixed reported bugs from the community
691+
- Additional integration tests and e2e tests are in Testgrid and linked in KEP
685692

686693
#### GA
687694

688-
- N examples of real-world usage
689-
- N installs
690-
- More rigorous forms of testing—e.g., downgrade tests and scalability tests
691-
- Allowing time for feedback
692-
693-
**Note:** Generally we also wait at least two releases between beta and
694-
GA/stable, because there's no opportunity for user feedback, or even bug reports,
695-
in back-to-back releases.
696-
697-
**For non-optional features moving to GA, the graduation criteria must include
698-
[conformance tests].**
695+
- At least one of Container Runtimes which is not based on the classic container, gVisor for example, supports the updated CRI and released
696+
- Assuming no negative user feedback based on production experience, promote after 2 releases in beta.
697+
- [conformance tests] are added for `SupplementalGroupsPolicy` and `ContainerStatus.User` APIs
699698

700699
[conformance tests]: https://git.k8s.io/community/contributors/devel/sig-architecture/conformance-tests.md
701700

702-
#### Deprecation
703-
704-
- Announce deprecation and support policy of the existing flag
705-
- Two versions passed since introducing the functionality that deprecates the flag (to address version skew)
706-
- Address feedback on usage/changed behavior, provided on GitHub issues
707-
- Deprecate the flag
708-
-->
709-
710701
### Upgrade / Downgrade Strategy
711702

712703
<!--

0 commit comments

Comments
 (0)