Skip to content

Commit b53643f

Browse files
dinhxuanvuk8s-publishing-bot
authored andcommitted
Remove deprecated extra-dirs flag
The extra-dirs input is no longer in use. The extra-dirs flag, however, is still present even though it is not wired in conversion code. As a result, any extra dirs inputs are provided via extra-dirs flag are not taken in consideration for conversion-gen. This flag should be removed from args options to avoid confusion. Signed-off-by: Vu Dinh <[email protected]> Kubernetes-commit: 917aa9a8c4658a5cf870ab7e629a73534e3a1808
1 parent dd3711d commit b53643f

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

cmd/conversion-gen/args/args.go

-7
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,6 @@ type Args struct {
4545
// generator pick up manually written conversion funcs from external packages.
4646
ExtraPeerDirs []string
4747

48-
// Additional dirs to parse and load, but not consider for peers. This is
49-
// useful when packages depend on other packages and want to call
50-
// conversions across them.
51-
ExtraDirs []string
52-
5348
// SkipUnsafe indicates whether to generate unsafe conversions to improve the efficiency
5449
// of these operations. The unsafe operation is a direct pointer assignment via unsafe
5550
// (within the allowed uses of unsafe) and is equivalent to a proposed Golang change to
@@ -84,8 +79,6 @@ func (args *Args) AddFlags(fs *pflag.FlagSet) {
8479
"Comma-separated list of apimachinery import paths which are considered, after tag-specified peers, for conversions. Only change these if you have very good reasons.")
8580
fs.StringSliceVar(&args.ExtraPeerDirs, "extra-peer-dirs", args.ExtraPeerDirs,
8681
"Application specific comma-separated list of import paths which are considered, after tag-specified peers and base-peer-dirs, for conversions.")
87-
fs.StringSliceVar(&args.ExtraDirs, "extra-dirs", args.ExtraDirs,
88-
"Application specific comma-separated list of import paths which are loaded and considered for callable conversions, but are not considered peers for conversion.")
8982
fs.BoolVar(&args.SkipUnsafe, "skip-unsafe", args.SkipUnsafe,
9083
"If true, will not generate code using unsafe pointer conversions; resulting code may be slower.")
9184
fs.StringVar(&args.GoHeaderFile, "go-header-file", "",

0 commit comments

Comments
 (0)