Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPA: add document behavior for Requests & Limits #7927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

VPA: add document behavior for Requests & Limits #7927

wants to merge 1 commit into from

Conversation

novahe
Copy link
Contributor

@novahe novahe commented Mar 14, 2025 •
edited
Loading

What type of PR is this?

/kind documentation
/area vertical-pod-autoscaler

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #7895

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 14, 2025
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @novahe. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2025
@omerap12
Copy link
Member

cc @adrianmoisey ( if you wanna take a look too ).

@novahe novahe force-pushed the add-faq branch 3 times, most recently from 8089956 to 0252209 Compare March 16, 2025 08:43
@novahe novahe requested review from adrianmoisey and omerap12 March 16, 2025 08:44
omerap12
omerap12 approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@omerap12 omerap12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! lgtm from me.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: novahe, omerap12
Once this PR has been reviewed and has the lgtm label, please assign kwiesmueller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@novahe
Copy link
Contributor Author

novahe commented Mar 16, 2025

Thank you for your thorough review; it has been very beneficial to me.

@omerap12
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2025
@omerap12
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2025
@novahe novahe requested a review from adrianmoisey March 17, 2025 02:45
adrianmoisey
adrianmoisey reviewed Mar 17, 2025
View reviewed changes
vertical-pod-autoscaler/docs/faq.md
@@ -244,3 +245,15 @@ The `--webhook-labels` parameter for the VPA admission-controller can be used to
When running in EKS with Cilium, the EKS API server cannot route traffic to the overlay network. The VPA admission-controller
Pods either need to use host networking or be exposed through a service or ingress.
See the [Cilium Helm installation page](https://docs.cilium.io/en/stable/installation/k8s-install-helm/) for more info.

### Why does VPA fail to create a Pod when resource limits are explicitly set to 0?
VPA currently handles requests=0 and limits=0 inconsistently with Kubernetes, leading to invalid Pod configurations. Here’s the breakdown:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more change, could you make it clear that if a pod is created with requests=limits=0, that it will break and not work?

It's kind of implied here, but I think it needs to be explicitly called out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree ( this is why we opened this issue to begin with :) )

@omerap12
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@omerap12
Copy link
Member

Hey @novahe, are you still working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmoisey adrianmoisey adrianmoisey left review comments

@omerap12 omerap12 omerap12 approved these changes

@raywainman raywainman Awaiting requested review from raywainman

@voelzmo voelzmo Awaiting requested review from voelzmo

Assignees

@omerap12 omerap12

Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VPA: document behavior for Requests & Limits
4 participants
@novahe @k8s-ci-robot @omerap12 @adrianmoisey