moved test to e2e

Signed-off-by: Omer Aplatony <[email protected]>

Author: omerap12

vertical-pod-autoscaler/e2e/v1/admission_controller.go

@@ -983,6 +983,24 @@ var _ = AdmissionControllerE2eDescribe("Admission-controller", func() {
 					}
 				}
 			}`),
+			`spec.resourcePolicy.containerPolicies[0].mode: Unsupported value: "bad": supported values: "Auto", "Off"`: []byte(`{
+				"kind": "VerticalPodAutoscaler",
+				"apiVersion": "autoscaling.k8s.io/v1",
+				"metadata": {"name": "hamster-vpa-invalid-mode"},
+				"spec": {
+					"targetRef": {
+						"apiVersion": "apps/v1",
+						"kind": "Deployment",
+						"name": "hamster"
+					},
+					"resourcePolicy": {
+						"containerPolicies": [{
+							"containerName": "loot box",
+							"mode": "bad"
+						}]
+					},
+				}
+			}`),
 		}
 
 		var err2 error

vertical-pod-autoscaler/pkg/admission-controller/resource/vpa/handler_test.go

@@ -87,22 +87,6 @@ func TestValidateVPA(t *testing.T) {
 				},
 			},
 		},
-		{
-			name: "invalid scaling mode",
-			vpa: vpa_types.VerticalPodAutoscaler{
-				Spec: vpa_types.VerticalPodAutoscalerSpec{
-					ResourcePolicy: &vpa_types.PodResourcePolicy{
-						ContainerPolicies: []vpa_types.ContainerResourcePolicy{
-							{
-								ContainerName: "loot box",
-								Mode:          &badScalingMode,
-							},
-						},
-					},
-				},
-			},
-			expectError: fmt.Errorf("unexpected Mode value bad"),
-		},
 		{
 			name: "bad limits",
 			vpa: vpa_types.VerticalPodAutoscaler{