Skip to content

Commit 6aae451

Browse files
deads2kk8s-publishing-bot
authored andcommitted
Stop exposing list-via-watch from the server
With StreamingCollectionEncodingToJSON and StreamingCollectionEncodingToProtobuf, the WatchList must re-justify its necessity. To prevent an ecosystem from building around a feature that may not be promoted, we will stop serving list-via-watch until performance numbers can justify its inclusion. This also stops the kube-controller-manager from using the list-via-watch by default. The fallback is a regular list, so during the skew during an upgrade the "right" thing will happen and the new StreamingCollectionEncoding will be used. Kubernetes-commit: 660df229bf3929741cf31659187060d0c651dcf9
1 parent 345c8cf commit 6aae451

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pkg/features/kube_features.go

+2
Original file line numberDiff line numberDiff line change
@@ -415,5 +415,7 @@ var defaultVersionedKubernetesFeatureGates = map[featuregate.Feature]featuregate
415415
WatchList: {
416416
{Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha},
417417
{Version: version.MustParse("1.32"), Default: true, PreRelease: featuregate.Beta},
418+
// switch this back to false because the json and proto streaming encoders appear to work better.
419+
{Version: version.MustParse("1.33"), Default: false, PreRelease: featuregate.Beta},
418420
},
419421
}

0 commit comments

Comments
 (0)