Skip to content

Commit 21fdbb3

Browse files
Merge pull request #126136 from cici37/removeFG
Remove feature gate CustomResourceValidationExpressions Kubernetes-commit: 8f265b63050739937cd939c05a98def37002f1e8
2 parents 64bd347 + 34ee2ac commit 21fdbb3

File tree

9 files changed

+6
-14
lines changed

9 files changed

+6
-14
lines changed

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ require (
2626
gopkg.in/yaml.v2 v2.4.0
2727
k8s.io/api v0.0.0-20240720022854-7d5e5eaf3aef
2828
k8s.io/apimachinery v0.0.0-20240719223001-62791ecbc514
29-
k8s.io/apiserver v0.0.0-20240720024610-bd463169afb8
29+
k8s.io/apiserver v0.0.0-20240720104541-d681845e4f6a
3030
k8s.io/client-go v0.0.0-20240719063343-5130bd9e7862
3131
k8s.io/code-generator v0.0.0-20240720023521-ec3cc888df4c
3232
k8s.io/component-base v0.0.0-20240715183844-6f32dbe8ef25

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -369,8 +369,8 @@ k8s.io/api v0.0.0-20240720022854-7d5e5eaf3aef h1:srEy4lds3ddDhT+cxFy68Uvt3GVRTo3
369369
k8s.io/api v0.0.0-20240720022854-7d5e5eaf3aef/go.mod h1:SvpyE6bmVBf1ly5BaD4y6yym4ZpHrV2pa8tTRjcglaA=
370370
k8s.io/apimachinery v0.0.0-20240719223001-62791ecbc514 h1:r9/8IzTbEU+H8bAZ4DtiN8A4Lr7UXnfPoPsnbe50zZ8=
371371
k8s.io/apimachinery v0.0.0-20240719223001-62791ecbc514/go.mod h1:rsPdaZJfTfLsNJSQzNHQvYoTmxhoOEofxtOsF3rtsMo=
372-
k8s.io/apiserver v0.0.0-20240720024610-bd463169afb8 h1:FhaX6BBO2L/1sd5/G1pB+2K2Afycrju0hgmDDS0vBmw=
373-
k8s.io/apiserver v0.0.0-20240720024610-bd463169afb8/go.mod h1:UFdCOgZ0UgBzrSbF5rc3eVHS4OhIdbnIFYEITre8ZT8=
372+
k8s.io/apiserver v0.0.0-20240720104541-d681845e4f6a h1:Hcn+rrkkCCMuRxtWTpGdVZhrkfKiQkZI+peIJIRuqnM=
373+
k8s.io/apiserver v0.0.0-20240720104541-d681845e4f6a/go.mod h1:UFdCOgZ0UgBzrSbF5rc3eVHS4OhIdbnIFYEITre8ZT8=
374374
k8s.io/client-go v0.0.0-20240719063343-5130bd9e7862 h1:7pxBn9PlLxKT4L7sh5YE3nUt6dBajHFY6MitAvQ0K4E=
375375
k8s.io/client-go v0.0.0-20240719063343-5130bd9e7862/go.mod h1:Ku8rB5ecknMAlxaO9IDX/HkHUBKk6ku4yWmXJ3o4Uaw=
376376
k8s.io/code-generator v0.0.0-20240720023521-ec3cc888df4c h1:oiNPH9Y/YrQfxo8eTW/w71aBrSyr9MX/wGBKTwDSZsc=

pkg/apis/apiextensions/types_jsonschema.go

-1
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@ type JSONSchemaProps struct {
144144
XMapType *string
145145

146146
// x-kubernetes-validations -kubernetes-validations describes a list of validation rules written in the CEL expression language.
147-
// This field is an alpha-level. Using this field requires the feature gate `CustomResourceValidationExpressions` to be enabled.
148147
// +patchMergeKey=rule
149148
// +patchStrategy=merge
150149
// +listType=map

pkg/apis/apiextensions/v1/generated.proto

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/apiextensions/v1/types_jsonschema.go

-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@ type JSONSchemaProps struct {
189189
XMapType *string `json:"x-kubernetes-map-type,omitempty" protobuf:"bytes,43,opt,name=xKubernetesMapType"`
190190

191191
// x-kubernetes-validations describes a list of validation rules written in the CEL expression language.
192-
// This field is an alpha-level. Using this field requires the feature gate `CustomResourceValidationExpressions` to be enabled.
193192
// +patchMergeKey=rule
194193
// +patchStrategy=merge
195194
// +listType=map

pkg/apis/apiextensions/v1beta1/generated.proto

-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/apiextensions/v1beta1/types_jsonschema.go

-1
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@ type JSONSchemaProps struct {
189189
XMapType *string `json:"x-kubernetes-map-type,omitempty" protobuf:"bytes,43,opt,name=xKubernetesMapType"`
190190

191191
// x-kubernetes-validations describes a list of validation rules written in the CEL expression language.
192-
// This field is an alpha-level. Using this field requires the feature gate `CustomResourceValidationExpressions` to be enabled.
193192
// +patchMergeKey=rule
194193
// +patchStrategy=merge
195194
// +listType=map

pkg/generated/openapi/zz_generated.openapi.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/registry/customresource/strategy.go

+1-4
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ import (
4444
"k8s.io/apimachinery/pkg/util/validation/field"
4545
celconfig "k8s.io/apiserver/pkg/apis/cel"
4646
"k8s.io/apiserver/pkg/cel/common"
47-
"k8s.io/apiserver/pkg/features"
4847
"k8s.io/apiserver/pkg/registry/generic"
4948
apiserverstorage "k8s.io/apiserver/pkg/storage"
5049
"k8s.io/apiserver/pkg/storage/names"
@@ -76,9 +75,7 @@ type selectableField struct {
7675

7776
func NewStrategy(typer runtime.ObjectTyper, namespaceScoped bool, kind schema.GroupVersionKind, schemaValidator, statusSchemaValidator validation.SchemaValidator, structuralSchema *structuralschema.Structural, status *apiextensions.CustomResourceSubresourceStatus, scale *apiextensions.CustomResourceSubresourceScale, selectableFields []v1.SelectableField) customResourceStrategy {
7877
var celValidator *cel.Validator
79-
if utilfeature.DefaultFeatureGate.Enabled(features.CustomResourceValidationExpressions) {
80-
celValidator = cel.NewValidator(structuralSchema, true, celconfig.PerCallLimit) // CEL programs are compiled and cached here
81-
}
78+
celValidator = cel.NewValidator(structuralSchema, true, celconfig.PerCallLimit) // CEL programs are compiled and cached here
8279

8380
strategy := customResourceStrategy{
8481
ObjectTyper: typer,

0 commit comments

Comments
 (0)