update by codereview

Signed-off-by: dongjiang1989 <[email protected]>

Author: dongjiang1989

cmd/metrics-server/app/options/kubelet_client.go

@@ -112,7 +112,6 @@ func (o KubeletClientOptions) Config(restConfig *rest.Config) *client.KubeletCli
 		config.Client.TLSClientConfig = rest.TLSClientConfig{}      // empty TLS config --> no TLS
 	}
 	if o.InsecureKubeletTLS {
-		config.Client.TLSClientConfig = rest.TLSClientConfig{}
 		config.Client.TLSClientConfig.Insecure = true
 		config.Client.TLSClientConfig.NextProtos = []string{"http/1.1", "h2"}
 	}

cmd/metrics-server/app/options/kubelet_client_test.go

@@ -75,8 +75,13 @@ func TestConfig(t *testing.T) {
 			expectFunc: func() client.KubeletClientConfig {
 				e := expected
 				e.Client.Insecure = true
-				e.Client.CAFile = ""
-				e.Client.CAData = nil
+				e.Client.KeyFile = "KeyFile"
+				e.Client.KeyData = []byte("KeyData")
+				e.Client.CAFile = "CAFile"
+				e.Client.CAData = []byte("CAData")
+				e.Client.CertFile = "CertFile"
+				e.Client.CertData = []byte("CertData")
+				e.Client.NextProtos = []string{"http/1.1", "h2"}
 				return e
 			},
 		},