Skip to content

Commit ee0de33

Browse files
authored
Fix helm update (#481)
Signed-off-by: kerthcet <[email protected]>
1 parent 23d2e4c commit ee0de33

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -277,12 +277,12 @@ artifacts: kustomize helm
277277
$(KUSTOMIZE) build config/default -o artifacts/manifests.yaml
278278
@$(call clean-manifests)
279279
# Update the image tag and policy
280-
$(YQ) e '.image.repository = "$(IMAGE_REPO)" | .image.tag = "$(GIT_TAG)" | .image.pullPolicy = "IfNotPresent"' -i charts/lws/values.yaml
280+
$(YQ) e '.image.manager.repository = "$(IMAGE_REPO)" | .image.manager.tag = "$(GIT_TAG)" | .image.manager.pullPolicy = "IfNotPresent"' -i charts/lws/values.yaml
281281
# create the package. TODO: consider signing it
282282
$(HELM) package --version $(GIT_TAG) --app-version $(GIT_TAG) charts/lws -d artifacts/
283283
mv artifacts/lws-$(GIT_TAG).tgz artifacts/lws-chart-$(GIT_TAG).tgz
284284
# Revert the image changes
285-
$(YQ) e '.image.repository = "$(IMAGE_REGISTRY)/$(IMAGE_NAME)" | del(.image.tag) | .image.pullPolicy = "Always"' -i charts/lws/values.yaml
285+
$(YQ) e '.image.manager.repository = "$(IMAGE_REGISTRY)/$(IMAGE_NAME)" | del(.image.manager.tag) | .image.manager.pullPolicy = "Always"' -i charts/lws/values.yaml
286286

287287

288288
.PHONY: prometheus

charts/lws/values.yaml

-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ image:
1515
# tag, if defined will use the given image tag, else Chart.AppVersion will be used
1616
tag: main
1717
pullPolicy: IfNotPresent
18-
repository: us-central1-docker.pkg.dev/k8s-staging-images/lws/lws
19-
pullPolicy: Always
2018
podAnnotations: {}
2119
podSecurityContext:
2220
runAsNonRoot: true

hack/push-chart.sh

+3-3
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ set -o pipefail
2020

2121
DEST_CHART_DIR=${DEST_CHART_DIR:-bin/}
2222

23-
EXTRA_TAG=${EXTRA_TAG:-$(git branch --show-current)}
23+
EXTRA_TAG=${EXTRA_TAG:-$(git branch --show-current)}
2424
GIT_TAG=${GIT_TAG:-$(git describe --tags --dirty --always)}
2525

2626
STAGING_IMAGE_REGISTRY=${STAGING_IMAGE_REGISTRY:-us-central1-docker.pkg.dev/k8s-staging-images}
@@ -46,11 +46,11 @@ default_image_repo=$(${YQ} ".image.repository" charts/lws/values.yaml)
4646
readonly default_image_repo
4747

4848
# Update the image repo, tag and policy
49-
${YQ} e ".image.repository = \"${image_repository}\" | .image.tag = \"${chart_version}\" | .image.pullPolicy = \"IfNotPresent\"" -i charts/lws/values.yaml
49+
${YQ} e ".image.manager.repository = \"${image_repository}\" | .image.manager.tag = \"${chart_version}\" | .image.manager.pullPolicy = \"IfNotPresent\"" -i charts/lws/values.yaml
5050

5151
${HELM} package --version "${chart_version}" --app-version "${chart_version}" charts/lws -d "${DEST_CHART_DIR}"
5252

5353
# Revert the image changes
54-
${YQ} e ".image.repository = \"${default_image_repo}\" | .image.tag = \"main\" | .image.pullPolicy = \"Always\"" -i charts/lws/values.yaml
54+
${YQ} e ".image.manager.repository = \"${default_image_repo}\" | .image.manager.tag = \"main\" | .image.manager.pullPolicy = \"Always\"" -i charts/lws/values.yaml
5555

5656
${HELM} push "bin/lws-${chart_version}.tgz" "oci://${HELM_CHART_REPO}"

0 commit comments

Comments
 (0)