backend: pkg: portforward: Fix cache implementation and refactor shorten PortForward #3284
+324
−132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: fromsaurav The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
fromsaurav
force-pushed
the
refactor/3279-shorten-startportforward
branch
from
28eeac6 to
967aa8a
Compare
k8s-ci-robot
added
size/L
fromsaurav
changed the title
|
We follow a linux kernel style of commit messages. With the context at the front followed by an action word and the rest. Would you mind changing them to something like this? (but probably you can write them better).
See git log for some more examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor(backend/portforward): Shorten startPortForward function
This PR addresses issue #3279 by refactoring the internal
startPortForwardfunction inbackend/pkg/portforward/handler.go.Changes Made:
startPortForwardfunction was broken down into smaller, more manageable helper functions:getKubeClientAndConfiginitPortForwarderhandlePortForwardReadinessrunAndMonitorPortForwardmonitorPodAndManagePortForwardfunlenlinter warning previously associated with this function.//nolint:funlendirective has been removed from the refactoredstartPortForwardfunction.Testing:
make backend-lint) pass.make backend-testwithHEADLAMP_RUN_INTEGRATION_TESTS=trueagainst a Minikube cluster) pass.Fixes #3279