Skip to content

frontend: NamespacesAutocomplete: Show list of selected namespaces while hovering #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

frontend: NamespacesAutocomplete: Show list of selected namespaces while hovering #3235

merged 2 commits into from
May 20, 2025

Conversation

upsaurav12
Copy link
Contributor

Fixes #3232 ,
In PR user will able to see the list of other selected namespaces options while hovering to + sign.
To achieve this i have used useState hook for adding state for checking if the user is hovering or not. I have also used onMouseEnter and onMouseLeave for toggling hovering effect.

When the User hovers to + sign it will trigger onMouseEnter and isHovered = true. List will only show when isHovered is true.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @upsaurav12!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2025
skoeva
skoeva reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I think these commits can be squashed into one, also don't forget to run make frontend-test and update any outdated snapshots 🔥

@upsaurav12 upsaurav12 force-pushed the list-on-hover#3232 branch from 4ee4018 to 709f47f Compare May 15, 2025 03:25
@upsaurav12 upsaurav12 requested a review from skoeva May 15, 2025 22:11
@upsaurav12 upsaurav12 force-pushed the list-on-hover#3232 branch from a3fbac3 to 709f47f Compare May 16, 2025 17:19
@illume
Copy link
Contributor

illume commented May 16, 2025

Thanks @upsaurav12

Would you mind adding the component to the context part of the commit message? Also the first letter of the verb should be capitalized.
frontend: NamespacesAutocomplete: Show list of selected namespaces while hovering

Also please remove this from the commit message?

frontend: tooltip: used Tooltip component for hovering and showing list items
fix: fixed failing tests

@upsaurav12 upsaurav12 changed the title frontend: Hover : show list of selected namespaces while hovering frontend: NamespacesAutocomplete: Show list of selected namespaces while hovering May 16, 2025
@upsaurav12 upsaurav12 force-pushed the list-on-hover#3232 branch 2 times, most recently from e0d50e6 to 2aa3436 Compare May 16, 2025 18:45
@upsaurav12 upsaurav12 force-pushed the list-on-hover#3232 branch from 3597296 to 73b4aff Compare May 16, 2025 18:47
@upsaurav12
Copy link
Contributor Author

it was added in description when i squashed commits.

illume
illume approved these changes May 17, 2025
View reviewed changes
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: illume, upsaurav12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2025
@illume illume merged commit 0195f5e into kubernetes-sigs:main May 20, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sniok sniok sniok left review comments

@illume illume illume approved these changes

@joaquimrocha joaquimrocha Awaiting requested review from joaquimrocha

@skoeva skoeva Awaiting requested review from skoeva

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a list of selected namespaces while hovering.
5 participants
@upsaurav12 @k8s-ci-robot @illume @sniok @skoeva