Skip to content

i18n: Added tamil language #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

i18n: Added tamil language #3239

wants to merge 7 commits into from
+772 −0

Conversation

HarshSrivastava275
Copy link
Contributor

@HarshSrivastava275 HarshSrivastava275 commented May 15, 2025 •
edited
Loading

I have added tamil language for the headlamp website which will help people who knows tamil to efficiently interact with the site.

This resolves issue no:- #3223

Attached Screenshot for reference :-

Tamil

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 15, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 15, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @HarshSrivastava275!

It looks like this is your first PR to kubernetes-sigs/headlamp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/headlamp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HarshSrivastava275
Once this PR has been reviewed and has the lgtm label, please assign joaquimrocha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from skoeva and yolossn May 15, 2025 08:16
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 15, 2025
@illume illume added kind/feature Categorizes issue or PR as related to a new feature. a11y Accessibility related issues i18n labels May 15, 2025
@illume illume linked an issue May 15, 2025 that may be closed by this pull request
i18n: Add Tamil language #3223
Open
@illume
Copy link
Contributor

illume commented May 15, 2025 •
edited
Loading

Thank you! 🎉

I notice there's an issue with CI. You can run the check locally...
make frontend-i18n-check

It seems some files need to be updated. Can you please have a look?

For the commit message, we follow kernel style commit guidelines... Are you able to add the context to the message?
Like this: frontend: i18n: Add Tamil language

I'll leave the rest of this review to @yolossn

@HarshSrivastava275
Copy link
Contributor Author

HarshSrivastava275 commented May 15, 2025 via email

skoeva
skoeva reviewed May 15, 2025
View reviewed changes
Copy link
Contributor

@skoeva skoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run make frontend-i18n-check locally? That should take care of the failing frontend test in the CI

@HarshSrivastava275
Copy link
Contributor Author

HarshSrivastava275 commented May 15, 2025 via email

@illume
Copy link
Contributor

illume commented May 16, 2025

The Kubernetes and other jargon words are often not translated, because there are no good translations that make sense. Please consider if words like Kubernetes, and Pods are accurate?

@HarshSrivastava275
Copy link
Contributor Author

@illume I think their is some problem with the CI pipeline as the local checks are passing successfully.

Attached Screenshot:-

frontend-check

@illume
Copy link
Contributor

illume commented May 16, 2025

@HarshSrivastava275 Ok, thanks for the info. I'll try and reproduce the issue on my system.

@illume
Copy link
Contributor

illume commented May 16, 2025

I rebased it against main, and there were a few newer translation strings added. So I think this was causing CI to fail.

These are the new ones:

+  "Use evict for pod deletion": "",
+  "Evict": "",
+  "Evict Pod": "",
+  "Are you sure you want to evict pod {{ itemName }}?": "",
+  "Force Delete": "",

I pushed the changes to your branch.

@HarshSrivastava275
Copy link
Contributor Author

@yolossn I have done the required changes you can review.

yolossn
yolossn reviewed May 19, 2025
View reviewed changes
frontend/src/i18n/locales/ta/glossary.json Outdated
"List Kind": "பட்டியல் வகை",
"Served": "சேவை செய்தது",
"Storage": "சேமிப்பு",
"Objects": "வस्तுக்கள்",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this word is not translated properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This are translated properly I have used LLMs and cross verified it.

yolossn
yolossn requested changes May 19, 2025
View reviewed changes
Copy link
Contributor

@yolossn yolossn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HarshSrivastava275 I think we should stick to writing the technical terms like ingress, egress etc in tamil letters as is and not translate them. IMHO any native speaker wont be able to relate இன்புருள் to ingress. WDYT?

HarshSrivastava275 and others added 2 commits May 19, 2025 12:46
@HarshSrivastava275 @yolossn
Update frontend/src/i18n/locales/ta/glossary.json
8a16dd5 
Co-authored-by: S Santhosh Nagaraj <[email protected]>
Signed-off-by: HarshSrivastava275 <[email protected]>
@HarshSrivastava275 @yolossn
Update frontend/src/i18n/locales/ta/glossary.json
3128057 
Co-authored-by: S Santhosh Nagaraj <[email protected]>
Signed-off-by: HarshSrivastava275 <[email protected]>
@HarshSrivastava275
Copy link
Contributor Author

HarshSrivastava275 commented May 19, 2025 •
edited
Loading

@yolossn You can pair program as I think you are a native tamil speaker what do you say?Pull this branch and push the changes.

@HarshSrivastava275 HarshSrivastava275 changed the title Added tamil language i18n: Added tamil language May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yolossn yolossn yolossn requested changes

@skoeva skoeva skoeva left review comments

Assignees
No one assigned
Labels
a11y Accessibility related issues cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. i18n kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i18n: Add Tamil language
5 participants
@HarshSrivastava275 @k8s-ci-robot @illume @yolossn @skoeva