making isEvictable and hasSelectorOrAffinity invoked only once

googs1025 · googs1025 · commit acdf9c9153b3 · 2025-03-27T17:13:20.000+08:00
Signed-off-by: googs1025 &lt;googs1025@gmail.com&gt;
diff --git a/pkg/framework/plugins/removepodsviolatingtopologyspreadconstraint/topologyspreadconstraint.go b/pkg/framework/plugins/removepodsviolatingtopologyspreadconstraint/topologyspreadconstraint.go
@@ -433,7 +433,7 @@ func sortDomains(constraintTopologyPairs map[topologyPair][]*v1.Pod, isEvictable
 				// Sort by priority in ascending order (lower priority Pods first)
 				return !comparePodsByPriority(list[i], list[j])
 			}
-			return hasSelectorOrAffinity(*list[i]) && !hasSelectorOrAffinity(*list[j])
+			return hasSelectorOrAffinityI && !hasSelectorOrAffinityJ
 		})
 		sortedTopologies = append(sortedTopologies, topology{pair: pair, pods: list})
 	}

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ func sortDomains(constraintTopologyPairs map[topologyPair][]*v1.Pod, isEvictable`
`433`	`433`	`// Sort by priority in ascending order (lower priority Pods first)`
`434`	`434`	`return !comparePodsByPriority(list[i], list[j])`
`435`	`435`	`}`
`436`		`- return hasSelectorOrAffinity(list[i]) && !hasSelectorOrAffinity(list[j])`
	`436`	`+ return hasSelectorOrAffinityI && !hasSelectorOrAffinityJ`
`437`	`437`	`})`
`438`	`438`	`sortedTopologies = append(sortedTopologies, topology{pair: pair, pods: list})`
`439`	`439`	`}`