Skip to content

Commit c2f66a9

Browse files
authored
Merge pull request #10355 from pravarag/update-kcp-status-docs
📖 Improve docs for KCP.status.ready & cluster.status.ControlPlaneReady
2 parents ab7b580 + 6a93dc1 commit c2f66a9

File tree

5 files changed

+22
-7
lines changed

5 files changed

+22
-7
lines changed

api/v1beta1/cluster_types.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -412,7 +412,11 @@ type ClusterStatus struct {
412412
// +optional
413413
InfrastructureReady bool `json:"infrastructureReady"`
414414

415-
// ControlPlaneReady defines if the control plane is ready.
415+
// ControlPlaneReady denotes if the control plane became ready during initial provisioning
416+
// to receive requests.
417+
// NOTE: this field is part of the Cluster API contract and it is used to orchestrate provisioning.
418+
// The value of this field is never updated after provisioning is completed. Please use conditions
419+
// to check the operational state of the control plane.
416420
// +optional
417421
ControlPlaneReady bool `json:"controlPlaneReady"`
418422

api/v1beta1/zz_generated.openapi.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_clusters.yaml

+6-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_types.go

+5-2
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,11 @@ type KubeadmControlPlaneStatus struct {
270270
// +optional
271271
Initialized bool `json:"initialized"`
272272

273-
// Ready denotes that the KubeadmControlPlane API Server is ready to
274-
// receive requests.
273+
// Ready denotes that the KubeadmControlPlane API Server became ready during initial provisioning
274+
// to receive requests.
275+
// NOTE: this field is part of the Cluster API contract and it is used to orchestrate provisioning.
276+
// The value of this field is never updated after provisioning is completed. Please use conditions
277+
// to check the operational state of the control plane.
275278
// +optional
276279
Ready bool `json:"ready"`
277280

controlplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanes.yaml

+5-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)