Skip to content

Commit 580172b

Browse files
committed
Temp Changes
1 parent 8b3ece5 commit 580172b

File tree

1 file changed

+17
-23
lines changed

1 file changed

+17
-23
lines changed

hack/tools/release/notes/list_test.go

Lines changed: 17 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -69,45 +69,45 @@ func Test_buildSetOfPRNumbers(t *testing.T) {
6969
func Test_githubFromToPRLister_listPRs(t *testing.T) {
7070
tests := []struct {
7171
name string
72-
fields *githubFromToPRLister
72+
lister *githubFromToPRLister
7373
args ref
7474
wantErr bool
7575
}{
7676
{
7777
name: "Successful PR Listing",
7878
fields: &githubFromToPRLister{
7979
client: &githubClient{
80-
repo: "kubernetes-sigs/kind",
80+
repo: "kubernetes-sigs/cluster-api",
8181
},
8282
fromRef: ref{
8383
reType: "tags",
84-
value: "v0.26.0",
84+
value: "v1.10.0",
8585
},
8686
toRef: ref{
8787
reType: "tags",
88-
value: "v0.27.0",
88+
value: "v1.10.1",
8989
},
9090
branch: "main",
9191
},
9292
args: ref{
9393
reType: "tags",
94-
value: "v0.26.0",
94+
value: "v1.10.0",
9595
},
9696
wantErr: false,
9797
},
9898
{
9999
name: "Setting previousReleaseRef.value blank - should use toRef and fromRef from fields",
100100
fields: &githubFromToPRLister{
101101
client: &githubClient{
102-
repo: "kubernetes-sigs/kind",
102+
repo: "kubernetes-sigs/cluster-api",
103103
},
104104
fromRef: ref{
105105
reType: "tags",
106-
value: "v0.26.0",
106+
value: "v0.10.0",
107107
},
108108
toRef: ref{
109109
reType: "tags",
110-
value: "v0.27.0",
110+
value: "v0.10.1",
111111
},
112112
branch: "main",
113113
},
@@ -121,33 +121,33 @@ func Test_githubFromToPRLister_listPRs(t *testing.T) {
121121
name: "Create PR List when fromRef is not set",
122122
fields: &githubFromToPRLister{
123123
client: &githubClient{
124-
repo: "kubernetes-sigs/kind",
124+
repo: "kubernetes-sigs/cluster-api",
125125
},
126126
toRef: ref{
127127
reType: "tags",
128-
value: "v0.27.0",
128+
value: "v0.10.1",
129129
},
130130
branch: "main",
131131
},
132132
args: ref{
133133
reType: "tags",
134-
value: "v0.26.0",
134+
value: "v0.10.0",
135135
},
136136
wantErr: false,
137137
},
138138
{
139139
name: "Fail when previousReleaseRef.value is set to invalid",
140140
fields: &githubFromToPRLister{
141141
client: &githubClient{
142-
repo: "kubernetes-sigs/kind",
142+
repo: "kubernetes-sigs/cluster-api",
143143
},
144144
fromRef: ref{
145145
reType: "tags",
146-
value: "v0.26.0",
146+
value: "v0.10.0",
147147
},
148148
toRef: ref{
149149
reType: "tags",
150-
value: "v0.27.0",
150+
value: "v0.10.1",
151151
},
152152
branch: "main",
153153
},
@@ -161,11 +161,11 @@ func Test_githubFromToPRLister_listPRs(t *testing.T) {
161161
name: "Fail when toRef and previousReleaseRef set blank",
162162
fields: &githubFromToPRLister{
163163
client: &githubClient{
164-
repo: "kubernetes-sigs/kind",
164+
repo: "kubernetes-sigs/cluster-api",
165165
},
166166
fromRef: ref{
167167
reType: "tags",
168-
value: "v0.26.0",
168+
value: "v0.10.0",
169169
},
170170
toRef: ref{
171171
reType: "tags",
@@ -182,13 +182,7 @@ func Test_githubFromToPRLister_listPRs(t *testing.T) {
182182
}
183183
for _, tt := range tests {
184184
t.Run(tt.name, func(t *testing.T) {
185-
l := &githubFromToPRLister{
186-
client: tt.fields.client,
187-
fromRef: tt.fields.fromRef,
188-
toRef: tt.fields.toRef,
189-
branch: tt.fields.branch,
190-
}
191-
_, err := l.listPRs(tt.args)
185+
_, err := tt.lister.listPRs(tt.args)
192186
if (err != nil) != tt.wantErr {
193187
t.Errorf("githubFromToPRLister.listPRs() error = %v, wantErr %v", err, tt.wantErr)
194188
return

0 commit comments

Comments
 (0)