@@ -69,45 +69,45 @@ func Test_buildSetOfPRNumbers(t *testing.T) {
69
69
func Test_githubFromToPRLister_listPRs (t * testing.T ) {
70
70
tests := []struct {
71
71
name string
72
- fields * githubFromToPRLister
72
+ lister * githubFromToPRLister
73
73
args ref
74
74
wantErr bool
75
75
}{
76
76
{
77
77
name : "Successful PR Listing" ,
78
78
fields : & githubFromToPRLister {
79
79
client : & githubClient {
80
- repo : "kubernetes-sigs/kind " ,
80
+ repo : "kubernetes-sigs/cluster-api " ,
81
81
},
82
82
fromRef : ref {
83
83
reType : "tags" ,
84
- value : "v0.26 .0" ,
84
+ value : "v1.10 .0" ,
85
85
},
86
86
toRef : ref {
87
87
reType : "tags" ,
88
- value : "v0.27.0 " ,
88
+ value : "v1.10.1 " ,
89
89
},
90
90
branch : "main" ,
91
91
},
92
92
args : ref {
93
93
reType : "tags" ,
94
- value : "v0.26 .0" ,
94
+ value : "v1.10 .0" ,
95
95
},
96
96
wantErr : false ,
97
97
},
98
98
{
99
99
name : "Setting previousReleaseRef.value blank - should use toRef and fromRef from fields" ,
100
100
fields : & githubFromToPRLister {
101
101
client : & githubClient {
102
- repo : "kubernetes-sigs/kind " ,
102
+ repo : "kubernetes-sigs/cluster-api " ,
103
103
},
104
104
fromRef : ref {
105
105
reType : "tags" ,
106
- value : "v0.26 .0" ,
106
+ value : "v0.10 .0" ,
107
107
},
108
108
toRef : ref {
109
109
reType : "tags" ,
110
- value : "v0.27.0 " ,
110
+ value : "v0.10.1 " ,
111
111
},
112
112
branch : "main" ,
113
113
},
@@ -121,33 +121,33 @@ func Test_githubFromToPRLister_listPRs(t *testing.T) {
121
121
name : "Create PR List when fromRef is not set" ,
122
122
fields : & githubFromToPRLister {
123
123
client : & githubClient {
124
- repo : "kubernetes-sigs/kind " ,
124
+ repo : "kubernetes-sigs/cluster-api " ,
125
125
},
126
126
toRef : ref {
127
127
reType : "tags" ,
128
- value : "v0.27.0 " ,
128
+ value : "v0.10.1 " ,
129
129
},
130
130
branch : "main" ,
131
131
},
132
132
args : ref {
133
133
reType : "tags" ,
134
- value : "v0.26 .0" ,
134
+ value : "v0.10 .0" ,
135
135
},
136
136
wantErr : false ,
137
137
},
138
138
{
139
139
name : "Fail when previousReleaseRef.value is set to invalid" ,
140
140
fields : & githubFromToPRLister {
141
141
client : & githubClient {
142
- repo : "kubernetes-sigs/kind " ,
142
+ repo : "kubernetes-sigs/cluster-api " ,
143
143
},
144
144
fromRef : ref {
145
145
reType : "tags" ,
146
- value : "v0.26 .0" ,
146
+ value : "v0.10 .0" ,
147
147
},
148
148
toRef : ref {
149
149
reType : "tags" ,
150
- value : "v0.27.0 " ,
150
+ value : "v0.10.1 " ,
151
151
},
152
152
branch : "main" ,
153
153
},
@@ -161,11 +161,11 @@ func Test_githubFromToPRLister_listPRs(t *testing.T) {
161
161
name : "Fail when toRef and previousReleaseRef set blank" ,
162
162
fields : & githubFromToPRLister {
163
163
client : & githubClient {
164
- repo : "kubernetes-sigs/kind " ,
164
+ repo : "kubernetes-sigs/cluster-api " ,
165
165
},
166
166
fromRef : ref {
167
167
reType : "tags" ,
168
- value : "v0.26 .0" ,
168
+ value : "v0.10 .0" ,
169
169
},
170
170
toRef : ref {
171
171
reType : "tags" ,
@@ -182,13 +182,7 @@ func Test_githubFromToPRLister_listPRs(t *testing.T) {
182
182
}
183
183
for _ , tt := range tests {
184
184
t .Run (tt .name , func (t * testing.T ) {
185
- l := & githubFromToPRLister {
186
- client : tt .fields .client ,
187
- fromRef : tt .fields .fromRef ,
188
- toRef : tt .fields .toRef ,
189
- branch : tt .fields .branch ,
190
- }
191
- _ , err := l .listPRs (tt .args )
185
+ _ , err := tt .lister .listPRs (tt .args )
192
186
if (err != nil ) != tt .wantErr {
193
187
t .Errorf ("githubFromToPRLister.listPRs() error = %v, wantErr %v" , err , tt .wantErr )
194
188
return
0 commit comments