Skip to content

Commit 507ea09

Browse files
committed
Updates from review
1 parent 6d2fb96 commit 507ea09

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

docs/proposals/20210310-opt-in-autoscaling-from-zero.md

+9-8
Original file line numberDiff line numberDiff line change
@@ -195,19 +195,20 @@ type DockerMachineTemplate struct {
195195
```
196196
_Note: the `ResourceList` and `ResourceName` referenced are from k8s.io/api/core/v1`_
197197

198-
`platform.NodeInfo` is a struct that contains the architecture and operating system information of the node, to
199-
implement in the `util` package of the `cluster-api` project. The defined types and constants are exported for use by the
200-
cluster-api providers integrations.
198+
`platform.NodeInfo` is a struct that contains the architecture and operating system information of the node, to implement
199+
in the providers integration code.
201200
Its definition would look like this:
202201

203202
```go
204203
package platform
205204

206-
// Architecture represents the architecture of the node. Its underlying type is a string.
205+
// Architecture represents the CPU architecture of the node. Its underlying type is a string.
206+
// Its underlying type is a string and its value can be any of amd64, arm64, s390x, ppc64le.
207+
// +kubebuilder:validation:Enum=amd64;arm64;s390x;ppc64le
207208
// +enum
208209
type Architecture string
209210

210-
// Architecture constants defined for clarity and to be used by the cluster-api providers.
211+
// Architecture constants defined for clarity.
211212
const (
212213
ArchitectureAmd64 Architecture = "amd64"
213214
ArchitectureArm64 Architecture = "arm64"
@@ -217,11 +218,11 @@ const (
217218

218219
// NodeInfo contains information about the node's architecture and operating system.
219220
type NodeInfo struct {
220-
// Architecture is the architecture of the node. It is a string that can be any of (amd64, arm64, s390x, ppc64le).
221+
// architecture is the CPU architecture of the node.
222+
// Its underlying type is a string and its value can be any of amd64, arm64, s390x, ppc64le.
221223
// +optional
222-
// +kubebuilder:validation:Enum=amd64;arm64;s390x;ppc64le
223224
Architecture Architecture `json:"architecture,omitempty"`
224-
// OperatingSystem is a string representing the operating system of the node.
225+
// operatingSystem is a string representing the operating system of the node.
225226
// +optional
226227
OperatingSystem string `json:"operatingSystem,omitempty"`
227228
}

0 commit comments

Comments
 (0)