Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] metrics-bind-addr should be removed from cluster-api-operator documentation #765

Open
jokuniew opened this issue Mar 31, 2025 · 1 comment
Labels
needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jokuniew
Copy link

jokuniew commented Mar 31, 2025

metrics-bind-addr was removed in v1.9.0 release

kubernetes-sigs/cluster-api#11140
https://github.com/kubernetes-sigs/cluster-api/blob/155e6604aea01770c979631265c057e5e7eff45e/CHANGELOG/v1.9.0.md

the flag's code was removed in
https://github.com/kubernetes-sigs/cluster-api-operator/pull/665/files

but cluster-api-operator documentation still reffers to it
https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/docs/README.md?plain=1#L158

Just removing this one line from the documentation might not be enough; I believe that the documentation on collecting metrics should be revisited.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 31, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI Operator contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

2 participants