Skip to content

HelmReleaseProxy can't be created when there is a HelmChartProxy with the same name in a different namespace #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jds9090 opened this issue Feb 21, 2024 · 1 comment · Fixed by #177
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@jds9090
Copy link
Contributor

jds9090 commented Feb 21, 2024

What steps did you take and what happened:

Steps to reproduce

  • Create Cluster A with clusterSelector(cluster.x-k8s.io/cluster-name: A) in namespace ns1
  • Create Cluster A(same name) with clusterSelector(cluster.x-k8s.io/cluster-name: A) in namespace ns2
ubuntu@infra-bastion:~/jds$ k get cluster --show-labels -A
NAMESPACE                              NAME              PHASE          AGE     VERSION   LABELS
5c7792e2-0f2b-4fc8-b04a-3a7cf42b7460   ci-jds-cp-test    Provisioned    4h7m              cluster.x-k8s.io/cluster-name=ci-jds-cp-test
b5eb2819-5f6d-4a7c-b758-16da1be285cd   ci-jds-cp-test    Provisioned    155m              cluster.x-k8s.io/cluster-name=ci-jds-cp-test
  • Create HCP A in namespace ns1
  • Create HCP A(same name) in namespace ns2
ubuntu@infra-bastion:~/jds$ k get hcp -A
NAMESPACE                              NAME                       READY   REASON
5c7792e2-0f2b-4fc8-b04a-3a7cf42b7460   ci-jds-cp-test-ccm         False   HelmInstallOrUpgradeFailed @ HelmReleaseProxy/openstack-cloud-controller-manager-ci-jds-cp-test-r5jln
b5eb2819-5f6d-4a7c-b758-16da1be285cd   ci-jds-cp-test-ccm         True 

  • HCP A creates HRP X for Cluster A in namespace ns1
  • HCP A can't create HRP Y for Cluster A in namespace ns2
ubuntu@infra-bastion:~/jds$ k get hrp -A           
NAMESPACE                              NAME                                                       CLUSTER           READY   REASON                       STATUS            REVISION    
5c7792e2-0f2b-4fc8-b04a-3a7cf42b7460   openstack-cloud-controller-manager-ci-jds-cp-test-r5jln    ci-jds-cp-test    False   HelmInstallOrUpgradeFailed               

What did you expect to happen:

HCP A should create HRP Y for Cluster A in namespace ns2

Anything else you would like to add:

This is because the namespace of HCP is omitted when listing HRPs related to the HCP.

As a result, the addon can't be installed for Cluster A in namespace ns2

I already have a PR to fix this.

Environment:

  • Cluster API version: v1.5.3
  • Cluster API Add-on Provider for Helm version: v0.1.0-alpha.10
  • minikube/kind version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind bug

@Jont828
Copy link
Contributor

Jont828 commented Feb 21, 2024

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
3 participants