feat: add accountQuota parameter

Author: andyzhangx

pkg/azurefile/azurefile.go

@@ -870,6 +870,20 @@ func (d *Driver) ResizeFileShare(ctx context.Context, subsID, resourceGroup, acc
 	})
 }
 
+func (d *Driver) GetTotalQuotaGB(ctx context.Context, subsID, resourceGroup, accountName string) (int32, int32, error) {
+	fileshares, err := d.cloud.FileClient.WithSubscriptionID(subsID).ListFileShare(ctx, resourceGroup, accountName, "", "")
+	if err != nil {
+		return -1, -1, err
+	}
+	var totalQuotaGB int32
+	for _, fs := range fileshares {
+		if fs.ShareQuota != nil {
+			totalQuotaGB += *fs.ShareQuota
+		}
+	}
+	return totalQuotaGB, int32(len(fileshares)), nil
+}
+
 // RemoveStorageAccountTag remove tag from storage account
 func (d *Driver) RemoveStorageAccountTag(ctx context.Context, subsID, resourceGroup, account, key string) error {
 	// search in cache first

pkg/azurefile/controllerserver.go

@@ -77,6 +77,7 @@ var (
 			Mode: csi.VolumeCapability_AccessMode_MULTI_NODE_MULTI_WRITER,
 		},
 	}
+	skipMatchingTag = map[string]*string{azure.SkipMatchingTag: pointer.String("")}
 )
 
 // CreateVolume provisions an azure file
@@ -452,6 +453,20 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
 				if err != nil {
 					return nil, status.Errorf(codes.Internal, "failed to ensure storage account: %v", err)
 				}
+				totalQuotaGB, fileshareNum, err := d.GetTotalQuotaGB(ctx, subsID, resourceGroup, accountName)
+				if err != nil {
+					return nil, status.Errorf(codes.Internal, "failed to get total quota on account(%s), error: %v", accountName, err)
+				}
+				klog.V(2).Infof("total used quota on account(%s) is %d GB, file share number: %d", accountName, totalQuotaGB, fileshareNum)
+				if totalQuotaGB > 81920 {
+					klog.Warningf("account(%s) used quota(%d GB) is over 81920 GB, skip matching current account", accountName, totalQuotaGB)
+					if rerr := d.cloud.AddStorageAccountTags(ctx, subsID, resourceGroup, accountName, skipMatchingTag); rerr != nil {
+						klog.Warningf("AddStorageAccountTags(%v) on account(%s) subsID(%s) rg(%s) failed with error: %v", tags, accountName, subsID, resourceGroup, rerr.Error())
+					}
+					// release volume lock first to prevent deadlock
+					d.volumeLocks.Release(volName)
+					return d.CreateVolume(ctx, req)
+				}
 				d.accountSearchCache.Set(lockKey, accountName)
 				d.volMap.Store(volName, accountName)
 				if accountKey != "" {
@@ -502,10 +517,7 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
 	if err := d.CreateFileShare(ctx, accountOptions, shareOptions, secret); err != nil {
 		if strings.Contains(err.Error(), accountLimitExceedManagementAPI) || strings.Contains(err.Error(), accountLimitExceedDataPlaneAPI) {
 			klog.Warningf("create file share(%s) on account(%s) type(%s) subID(%s) rg(%s) location(%s) size(%d), error: %v, skip matching current account", validFileShareName, accountName, sku, subsID, resourceGroup, location, fileShareSize, err)
-			tags := map[string]*string{
-				azure.SkipMatchingTag: pointer.String(""),
-			}
-			if rerr := d.cloud.AddStorageAccountTags(ctx, subsID, resourceGroup, accountName, tags); rerr != nil {
+			if rerr := d.cloud.AddStorageAccountTags(ctx, subsID, resourceGroup, accountName, skipMatchingTag); rerr != nil {
 				klog.Warningf("AddStorageAccountTags(%v) on account(%s) subsID(%s) rg(%s) failed with error: %v", tags, accountName, subsID, resourceGroup, rerr.Error())
 			}
 			// release volume lock first to prevent deadlock
@@ -514,7 +526,7 @@ func (d *Driver) CreateVolume(ctx context.Context, req *csi.CreateVolumeRequest)
 			if err := d.accountSearchCache.Delete(lockKey); err != nil {
 				return nil, status.Errorf(codes.Internal, err.Error())
 			}
-			// remove the volName from the volMap to stop it matching the same storage account
+			// remove the volName from the volMap to stop matching the same storage account
 			d.volMap.Delete(volName)
 			return d.CreateVolume(ctx, req)
 		}

pkg/azurefile/controllerserver_test.go

@@ -895,7 +895,7 @@ func TestCreateVolume(t *testing.T) {
 				mockStorageAccountsClient.EXPECT().ListByResourceGroup(gomock.Any(), gomock.Any(), gomock.Any()).Return(accounts, nil).AnyTimes()
 				mockStorageAccountsClient.EXPECT().Create(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).AnyTimes()
 				mockFileClient.EXPECT().GetFileShare(context.TODO(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(storage.FileShare{FileShareProperties: &storage.FileShareProperties{ShareQuota: nil}}, fmt.Errorf("test error")).AnyTimes()
-
+				mockFileClient.EXPECT().ListFileShare(context.TODO(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return([]storage.FileShareItem{}, nil).AnyTimes()
 				d.AddControllerServiceCapabilities(
 					[]csi.ControllerServiceCapability_RPC_Type{
 						csi.ControllerServiceCapability_RPC_CREATE_DELETE_VOLUME,