Merge pull request #1893 from kubernetes-sigs/rollingupdate

feat: add node.maxUnavailable parameter in chart config

Author: andyzhangx

charts/latest/azurefile-csi-driver-v0.0.0.tgz

@@ -19,6 +19,8 @@ spec:
     matchLabels:
       {{- include "azurefile.selectorLabels" . | nindent 6 }}
       app: {{ .Values.controller.name }}
+  strategy:
+    type: {{ .Values.controller.strategyType }}
   template:
     metadata:
       labels:

charts/latest/azurefile-csi-driver/templates/csi-azurefile-controller.yaml

@@ -18,7 +18,7 @@ spec:
   updateStrategy:
     rollingUpdate:
       maxUnavailable: {{ .Values.node.maxUnavailable }}
-    type: RollingUpdate
+    type: {{ .Values.node.strategyType }}
   selector:
     matchLabels:
       app: {{ .Values.windows.dsName }}

charts/latest/azurefile-csi-driver/templates/csi-azurefile-node-windows-hostprocess.yaml

@@ -18,7 +18,7 @@ spec:
   updateStrategy:
     rollingUpdate:
       maxUnavailable: {{ .Values.node.maxUnavailable }}
-    type: RollingUpdate
+    type: {{ .Values.node.strategyType }}
   selector:
     matchLabels:
       app: {{ .Values.windows.dsName }}

charts/latest/azurefile-csi-driver/templates/csi-azurefile-node-windows.yaml

@@ -18,7 +18,7 @@ spec:
   updateStrategy:
     rollingUpdate:
       maxUnavailable: {{ .Values.node.maxUnavailable }}
-    type: RollingUpdate
+    type: {{ .Values.node.strategyType }}
   selector:
     matchLabels:
       app: {{ .Values.linux.dsName }}

charts/latest/azurefile-csi-driver/templates/csi-azurefile-node.yaml

@@ -28,7 +28,7 @@ spec:
     rollingUpdate:
       maxSurge: 0
       maxUnavailable: 1
-    type: RollingUpdate
+    type: {{ .Values.snapshot.snapshotController.strategyType }}
   template:
     metadata:
       labels:

charts/latest/azurefile-csi-driver/templates/csi-snapshot-controller.yaml

@@ -46,6 +46,7 @@ controller:
   cloudConfigSecretNamespace: kube-system
   allowEmptyCloudConfig: true
   replicas: 2
+  strategyType: RollingUpdate
   hostNetwork: true # this setting could be disabled if controller does not depend on MSI setting
   metricsPort: 29614
   livenessProbe:
@@ -109,6 +110,8 @@ controller:
       effect: "NoSchedule"
 
 node:
+  strategyType: RollingUpdate
+  maxUnavailable: 1
   cloudConfigSecretName: azure-cloud-provider
   cloudConfigSecretNamespace: kube-system
   allowEmptyCloudConfig: true
@@ -132,6 +135,7 @@ snapshot:
   snapshotController:
     name: csi-snapshot-controller
     replicas: 2
+    strategyType: RollingUpdate
     labels: {}
     annotations: {}
     podLabels: {}

charts/latest/azurefile-csi-driver/values.yaml

@@ -19,6 +19,8 @@ spec:
     matchLabels:
       {{- include "azurefile.selectorLabels" . | nindent 6 }}
       app: {{ .Values.controller.name }}
+  strategy:
+    type: {{ .Values.controller.strategyType }}
   template:
     metadata:
       labels:

charts/v1.30.2/azurefile-csi-driver-v1.30.2.tgz

@@ -18,7 +18,7 @@ spec:
   updateStrategy:
     rollingUpdate:
       maxUnavailable: {{ .Values.node.maxUnavailable }}
-    type: RollingUpdate
+    type: {{ .Values.node.strategyType }}
   selector:
     matchLabels:
       app: {{ .Values.windows.dsName }}

charts/v1.30.2/azurefile-csi-driver/templates/csi-azurefile-controller.yaml

@@ -18,7 +18,7 @@ spec:
   updateStrategy:
     rollingUpdate:
       maxUnavailable: {{ .Values.node.maxUnavailable }}
-    type: RollingUpdate
+    type: {{ .Values.node.strategyType }}
   selector:
     matchLabels:
       app: {{ .Values.windows.dsName }}

charts/v1.30.2/azurefile-csi-driver/templates/csi-azurefile-node-windows-hostprocess.yaml

@@ -28,7 +28,7 @@ spec:
     rollingUpdate:
       maxSurge: 0
       maxUnavailable: 1
-    type: RollingUpdate
+    type: {{ .Values.snapshot.snapshotController.strategyType }}
   template:
     metadata:
       labels:

charts/v1.30.2/azurefile-csi-driver/templates/csi-azurefile-node-windows.yaml

@@ -46,6 +46,7 @@ controller:
   cloudConfigSecretNamespace: kube-system
   allowEmptyCloudConfig: true
   replicas: 2
+  strategyType: RollingUpdate
   hostNetwork: true # this setting could be disabled if controller does not depend on MSI setting
   metricsPort: 29614
   livenessProbe:
@@ -112,6 +113,8 @@ node:
   cloudConfigSecretName: azure-cloud-provider
   cloudConfigSecretNamespace: kube-system
   allowEmptyCloudConfig: true
+  strategyType: RollingUpdate
+  maxUnavailable: 1
   allowInlineVolumeKeyAccessWithIdentity: false
   metricsPort: 29615
   livenessProbe:
@@ -132,6 +135,7 @@ snapshot:
   snapshotController:
     name: csi-snapshot-controller
     replicas: 2
+    strategyType: RollingUpdate
     labels: {}
     annotations: {}
     podLabels: {}