Skip to content
This repository was archived by the owner on Apr 25, 2023. It is now read-only.

Commit 9821ccf

Browse files
authored
Merge pull request #1324 from makkes/improve-deployment-scripts
chore: improve some of the deployment and build scripts
2 parents 450c74b + c9659e7 commit 9821ccf

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

scripts/deploy-kubefed.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,10 @@ cd -
173173
deploy-with-helm
174174

175175
# Join the host cluster
176-
CONTEXT="$(kubectl config current-context)"
177-
./bin/kubefedctl join "${CONTEXT}" --host-cluster-context "${CONTEXT}" --v=2 "${KF_NS_ARGS}" --error-on-existing=false
176+
if [ -z "${NO_JOIN_HOST_CLUSTER:-}" ] ; then
177+
CONTEXT="$(kubectl config current-context)"
178+
./bin/kubefedctl join "${CONTEXT}" --host-cluster-context "${CONTEXT}" --v=2 "${KF_NS_ARGS}" --error-on-existing=false
179+
fi
178180

179181
for c in ${JOIN_CLUSTERS}; do
180182
./bin/kubefedctl join "${c}" --host-cluster-context "${CONTEXT}" --v=2 "${KF_NS_ARGS}" --error-on-existing=false

scripts/sync-up-helm-chart.sh

+5-4
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,11 @@ users: []
7878
EOF
7979

8080
# Start kube-apiserver to generate CRDs
81-
${ROOT_DIR}/bin/etcd --data-dir ${WORKDIR} &
82-
util::wait-for-condition 'ok' "curl http://127.0.0.1:2379/version &> /dev/null" 30
81+
${ROOT_DIR}/bin/etcd --data-dir ${WORKDIR} --log-output stdout > ${WORKDIR}/etcd.log 2>&1 &
82+
util::wait-for-condition 'etcd' "curl http://127.0.0.1:2379/version &> /dev/null" 30
8383

84-
${ROOT_DIR}/bin/kube-apiserver --etcd-servers=http://127.0.0.1:2379 --service-cluster-ip-range=10.0.0.0/16 --cert-dir ${WORKDIR} &
85-
util::wait-for-condition 'ok' "kubectl --kubeconfig ${WORKDIR}/kubeconfig --context kubefed get --raw=/healthz &> /dev/null" 60
84+
${ROOT_DIR}/bin/kube-apiserver --etcd-servers=http://127.0.0.1:2379 --service-cluster-ip-range=10.0.0.0/16 --cert-dir=${WORKDIR} --log-file=${WORKDIR}/kube-apiserver.log --logtostderr=false 2> /dev/null &
85+
util::wait-for-condition 'kube-apiserver' "kubectl --kubeconfig ${WORKDIR}/kubeconfig --context kubefed get --raw=/healthz &> /dev/null" 60
8686

8787
# Generate YAML templates to enable resource propagation for helm chart.
8888
echo -n > ${CHART_FEDERATED_PROPAGATION_DIR}/templates/federatedtypeconfig.yaml
@@ -104,3 +104,4 @@ done
104104
kill %1 # etcd
105105
kill %2 # kube-apiserver
106106
rm -fr ${WORKDIR}
107+
echo "Helm chart synced successfully"

0 commit comments

Comments
 (0)