Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

verify-gencode.sh can not work #788

Closed
hzxuzhonghu opened this issue Apr 16, 2019 · 7 comments
Closed

verify-gencode.sh can not work #788

hzxuzhonghu opened this issue Apr 16, 2019 · 7 comments

Comments

@hzxuzhonghu
Copy link
Contributor

No description provided.

@hzxuzhonghu
Copy link
Contributor Author

/cc @TommyLike

@TommyLike
Copy link
Contributor

@hzxuzhonghu any detail?

@hzxuzhonghu
Copy link
Contributor Author

hzxuzhonghu commented Apr 17, 2019

You can try to modify a generated files in client, rather than the deepcopy files, and make a commit.
Then make verify, it doesn't fail.

@TommyLike
Copy link
Contributor

@hzxuzhonghu yeah, the old logic only focus on deepcopy generated files. Try to update the make file with command:

verify: generate-code

may work as you expected.

@hzxuzhonghu
Copy link
Contributor Author

I think so. BTW, I understand the generate-code covers deepcopy, am i right?

@hzxuzhonghu hzxuzhonghu mentioned this issue Apr 17, 2019
@TommyLike
Copy link
Contributor

@hzxuzhonghu yeah. thanks!

@hzxuzhonghu
Copy link
Contributor Author

This is fixed by #792

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants