Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Commit fa74250

Browse files
author
Ziyang Wu
committed
Fix wrong caculation for deserved in proportion plugin
1 parent 38ad28b commit fa74250

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/scheduler/plugins/proportion/proportion.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,8 @@ func (pp *proportionPlugin) OnSessionOpen(ssn *framework.Session) {
124124
continue
125125
}
126126

127-
attr.deserved.Add(remaining.Clone().Multi(float64(attr.weight) / float64(totalWeight)))
127+
queueDeserved := remaining.Clone().Multi(float64(attr.weight) / float64(totalWeight))
128+
attr.deserved.Add(queueDeserved)
128129
if !attr.deserved.LessEqual(attr.request) {
129130
attr.deserved = helpers.Min(attr.deserved, attr.request)
130131
meet[attr.queueID] = struct{}{}
@@ -134,7 +135,7 @@ func (pp *proportionPlugin) OnSessionOpen(ssn *framework.Session) {
134135
glog.V(4).Infof("The attributes of queue <%s> in proportion: deserved <%v>, allocate <%v>, request <%v>, share <%0.2f>",
135136
attr.name, attr.deserved, attr.allocated, attr.request, attr.share)
136137

137-
deserved.Add(attr.deserved)
138+
deserved.Add(queueDeserved)
138139
}
139140

140141
remaining.Sub(deserved)

0 commit comments

Comments
 (0)