Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Commit 3e12cdb

Browse files
authored
Merge pull request #644 from TommyLike/bug/fix_typos
Fix Typos
2 parents 2bcd61f + 79b901d commit 3e12cdb

File tree

8 files changed

+12
-12
lines changed

8 files changed

+12
-12
lines changed

pkg/scheduler/actions/reclaim/reclaim.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ func (alloc *reclaimAction) Execute(ssn *framework.Session) {
176176

177177
if task.Resreq.LessEqual(reclaimed) {
178178
if err := ssn.Pipeline(task, n.Name); err != nil {
179-
glog.Errorf("Failed to pipline Task <%s/%s> on Node <%s>",
179+
glog.Errorf("Failed to pipeline Task <%s/%s> on Node <%s>",
180180
task.Namespace, task.Name, n.Name)
181181
}
182182

pkg/scheduler/api/helpers.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ func MergeErrors(errs ...error) error {
9696
return nil
9797
}
9898

99-
// JobTerminated checkes whether job was terminated.
99+
// JobTerminated checks whether job was terminated.
100100
func JobTerminated(job *JobInfo) bool {
101101
return job.PodGroup == nil &&
102102
job.PDB == nil &&

pkg/scheduler/api/job_info.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ type JobInfo struct {
141141
CreationTimestamp metav1.Time
142142
PodGroup *v1alpha1.PodGroup
143143

144-
// TODO(k82cn): keep backward compatbility, removed it when v1alpha1 finalized.
144+
// TODO(k82cn): keep backward compatibility, removed it when v1alpha1 finalized.
145145
PDB *policyv1.PodDisruptionBudget
146146
}
147147

pkg/scheduler/cache/event_handlers.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@ func (sc *SchedulerCache) setPodGroup(ss *kbv1.PodGroup) error {
363363
job := getJobID(ss)
364364

365365
if len(job) == 0 {
366-
return fmt.Errorf("the controller of PodGroup is empty")
366+
return fmt.Errorf("the identity of PodGroup is empty")
367367
}
368368

369369
if _, found := sc.Jobs[job]; !found {

pkg/scheduler/plugins/drf/drf.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -114,8 +114,8 @@ func (drf *drfPlugin) OnSessionOpen(ssn *framework.Session) {
114114
lv := l.(*api.JobInfo)
115115
rv := r.(*api.JobInfo)
116116

117-
glog.V(4).Infof("DRF JobOrderFn: <%v/%v> is ready: %d, <%v/%v> is ready: %d",
118-
lv.Namespace, lv.Name, lv.Priority, rv.Namespace, rv.Name, rv.Priority)
117+
glog.V(4).Infof("DRF JobOrderFn: <%v/%v> share state: %d, <%v/%v> share state: %d",
118+
lv.Namespace, lv.Name, drf.jobOpts[lv.UID].share, rv.Namespace, rv.Name, drf.jobOpts[rv.UID].share)
119119

120120
if drf.jobOpts[lv.UID].share == drf.jobOpts[rv.UID].share {
121121
return 0

pkg/scheduler/plugins/predicates/predicates.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -125,10 +125,10 @@ func (pp *predicatesPlugin) OnSessionOpen(ssn *framework.Session) {
125125
nodeInfo.SetNode(node.Node)
126126

127127
if node.Allocatable.MaxTaskNum <= len(nodeInfo.Pods()) {
128-
return fmt.Errorf("Node <%s> can not allow more task running on it.", node.Name)
128+
return fmt.Errorf("node <%s> can not allow more task running on it", node.Name)
129129
}
130130

131-
// NodeSeletor Predicate
131+
// NodeSelector Predicate
132132
fit, _, err := predicates.PodMatchNodeSelector(task.Pod, nil, nodeInfo)
133133
if err != nil {
134134
return err

pkg/scheduler/plugins/priority/priority.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func (pp *priorityPlugin) OnSessionOpen(ssn *framework.Session) {
4040
lv := l.(*api.TaskInfo)
4141
rv := r.(*api.TaskInfo)
4242

43-
glog.V(4).Infof("Priority TaskOrder: <%v/%v> prority is %v, <%v/%v> priority is %v",
43+
glog.V(4).Infof("Priority TaskOrder: <%v/%v> priority is %v, <%v/%v> priority is %v",
4444
lv.Namespace, lv.Name, lv.Priority, rv.Namespace, rv.Name, rv.Priority)
4545

4646
if lv.Priority == rv.Priority {
@@ -61,7 +61,7 @@ func (pp *priorityPlugin) OnSessionOpen(ssn *framework.Session) {
6161
lv := l.(*api.JobInfo)
6262
rv := r.(*api.JobInfo)
6363

64-
glog.V(4).Infof("Priority JobOrderFn: <%v/%v> is ready: %d, <%v/%v> is ready: %d",
64+
glog.V(4).Infof("Priority JobOrderFn: <%v/%v> priority: %d, <%v/%v> priority: %d",
6565
lv.Namespace, lv.Name, lv.Priority, rv.Namespace, rv.Name, rv.Priority)
6666

6767
if lv.Priority > rv.Priority {

pkg/scheduler/plugins/proportion/proportion.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ func (pp *proportionPlugin) OnSessionOpen(ssn *framework.Session) {
169169
}
170170
allocated := allocations[job.Queue]
171171
if allocated.Less(reclaimee.Resreq) {
172-
glog.Errorf("Failed to calculate the allocation of Task <%s/%s> in Queue <%s>.",
172+
glog.Errorf("Failed to allocate resource for Task <%s/%s> in Queue <%s>, not enough resource.",
173173
reclaimee.Namespace, reclaimee.Name, job.Queue)
174174
continue
175175
}
@@ -229,7 +229,7 @@ func (pp *proportionPlugin) OnSessionClose(ssn *framework.Session) {
229229
func (pp *proportionPlugin) updateShare(attr *queueAttr) {
230230
res := float64(0)
231231

232-
// TODO(k82cn): how to handle fragement issues?
232+
// TODO(k82cn): how to handle fragment issues?
233233
for _, rn := range api.ResourceNames() {
234234
share := helpers.Share(attr.allocated.Get(rn), attr.deserved.Get(rn))
235235
if share > res {

0 commit comments

Comments
 (0)