Skip to content

Use groupSnapshotUUID instead of groupSnapshotContentUUID to generate snapshot names #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xing-yang opened this issue Apr 25, 2025 · 0 comments · May be fixed by #1294
Open

Use groupSnapshotUUID instead of groupSnapshotContentUUID to generate snapshot names #1293

xing-yang opened this issue Apr 25, 2025 · 0 comments · May be fixed by #1294

Comments

@xing-yang
Copy link
Collaborator

What happened:
When generating a snapshot name before calling CSI driver to create a group snapshot, we used groupSnapshotContentUUID:

volumeSnapshotName := getSnapshotNameForVolumeGroupSnapshotContent(
string(groupSnapshotContent.UID), volumeHandle)

This individual snapshot name is not pass to CSI driver when creating a group snapshot, but some CSI drivers want to know this name. CSI drivers can generate this name, however, they don't know groupSnapshotContentUUID. They only know groupSnapshotUUID.

For the creation of individual VolumeSnapshot, we use content.Spec.VolumeSnapshotRef.UID when generating a snapshot name. Similarly here, we can use groupSnapshotContent.Spec.VolumeGroupSnapshotRef.UID instead of groupSnapshotContent.UID.

https://github.com/kubernetes-csi/external-snapshotter/blob/v8.2.1/pkg/sidecar-controller/csi_handler.go#L87

See discussions here:
https://kubernetes.slack.com/archives/C8EJ01Z46/p1745569386063539?thread_ts=1745569199.407819&cid=C8EJ01Z46

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • Driver version:
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant