fix superfluous response.WriteHeader (#4980)

zhangzujian · web-flow · commit d7714f991d5d · 2025-02-13T09:55:17.000+08:00
Signed-off-by: zhangzujian &lt;zhangzujian.7@gmail.com&gt;
diff --git a/pkg/util/health_check.go b/pkg/util/health_check.go
@@ -8,10 +8,6 @@ import (
 
 func DefaultHealthCheckHandler(w http.ResponseWriter, _ *http.Request) {
 	if _, err := w.Write([]byte("ok")); err != nil {
-		klog.Error(err)
-		w.WriteHeader(http.StatusInternalServerError)
-		return
+		klog.Errorf("failed to write health check response: %v", err)
 	}
-
-	w.WriteHeader(http.StatusOK)
 }

Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,6 @@ import (`
`8`	`8`
`9`	`9`	`func DefaultHealthCheckHandler(w http.ResponseWriter, _ *http.Request) {`
`10`	`10`	`if _, err := w.Write([]byte("ok")); err != nil {`
`11`		`- klog.Error(err)`
`12`		`- w.WriteHeader(http.StatusInternalServerError)`
`13`		`- return`
	`11`	`+ klog.Errorf("failed to write health check response: %v", err)`
`14`	`12`	`}`
`15`		`-`
`16`		`- w.WriteHeader(http.StatusOK)`
`17`	`13`	`}`