fix: clean up garbage lsp (#5172)

* clean up garbage lsp

Signed-off-by: clyi <[email protected]>

* fix

Signed-off-by: clyi <[email protected]>

* fix

Signed-off-by: clyi <[email protected]>

* fixx

Signed-off-by: clyi <[email protected]>

---------

Signed-off-by: clyi <[email protected]>

Author: changluyi

pkg/controller/node.go

@@ -130,6 +130,7 @@ func (c *Controller) handleAddNode(key string) error {
 	}
 
 	var v4IP, v6IP, mac string
+
 	portName := util.NodeLspName(key)
 	if node.Annotations[util.AllocatedAnnotation] == "true" && node.Annotations[util.IPAddressAnnotation] != "" && node.Annotations[util.MacAddressAnnotation] != "" {
 		macStr := node.Annotations[util.MacAddressAnnotation]
@@ -145,6 +146,13 @@ func (c *Controller) handleAddNode(key string) error {
 			klog.Errorf("failed to alloc random ip addrs for node %v: %v", node.Name, err)
 			return err
 		}
+
+		// Clean up potentially existing logical switch ports to avoid leftover issues from previous failed configurations
+		if err := c.OVNNbClient.DeleteLogicalSwitchPort(portName); err != nil {
+			klog.Errorf("failed to delete stale logical switch port %s: %v", portName, err)
+			return err
+		}
+		klog.Infof("deleted stale logical switch port %s", portName)
 	}
 
 	ipStr := util.GetStringIP(v4IP, v6IP)