Skip to content

Commit ffe30ca

Browse files
committed
Implement webhook validations for the XGBoostJob
Signed-off-by: Yuki Iwai <[email protected]>
1 parent 1a73cf1 commit ffe30ca

File tree

9 files changed

+427
-317
lines changed

9 files changed

+427
-317
lines changed

manifests/base/webhook/manifests.yaml

+20
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,23 @@ webhooks:
4444
resources:
4545
- tfjobs
4646
sideEffects: None
47+
- admissionReviewVersions:
48+
- v1
49+
clientConfig:
50+
service:
51+
name: webhook-service
52+
namespace: system
53+
path: /validate-kubeflow-org-v1-xgboostjob
54+
failurePolicy: Fail
55+
name: validator.xgboostjob.training-operator.kubeflow.org
56+
rules:
57+
- apiGroups:
58+
- kubeflow.org
59+
apiVersions:
60+
- v1
61+
operations:
62+
- CREATE
63+
- UPDATE
64+
resources:
65+
- xgboostjobs
66+
sideEffects: None

manifests/base/webhook/patch.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
- op: replace
55
path: /webhooks/1/clientConfig/service/name
66
value: training-operator
7+
- op: replace
8+
path: /webhooks/2/clientConfig/service/name
9+
value: training-operator
710
- op: replace
811
path: /metadata/name
912
value: validator.training-operator.kubeflow.org

pkg/apis/kubeflow.org/v1/xgboost_validation.go

-87
This file was deleted.

pkg/apis/kubeflow.org/v1/xgboost_validation_test.go

-222
This file was deleted.

0 commit comments

Comments
 (0)