File tree 1 file changed +4
-6
lines changed
1 file changed +4
-6
lines changed Original file line number Diff line number Diff line change @@ -46,12 +46,10 @@ type RuntimePolicy struct {
46
46
type Trainer struct {
47
47
NumNodes * int32
48
48
NumProcPerNode string
49
- // TODO (andreyvelich). Potentially, we can use map for env and sort it to improve code.
50
- // Context: https://github.com/kubeflow/trainer/pull/2308#discussion_r1823267183
51
- Env []corev1ac.EnvVarApplyConfiguration
52
- ContainerPort * corev1ac.ContainerPortApplyConfiguration
53
- Volumes []corev1ac.VolumeApplyConfiguration
54
- VolumeMounts []corev1ac.VolumeMountApplyConfiguration
49
+ Env []corev1ac.EnvVarApplyConfiguration
50
+ ContainerPort * corev1ac.ContainerPortApplyConfiguration
51
+ Volumes []corev1ac.VolumeApplyConfiguration
52
+ VolumeMounts []corev1ac.VolumeMountApplyConfiguration
55
53
}
56
54
57
55
// TODO (andreyvelich): Potentially, we can add ScheduleTimeoutSeconds to the Scheduler for consistency.
You can’t perform that action at this time.
0 commit comments