Skip to content

Commit 88fd72a

Browse files
committed
Remove obsolete TODO
1 parent 4417037 commit 88fd72a

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

pkg/runtime/runtime.go

+4-6
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,10 @@ type RuntimePolicy struct {
4646
type Trainer struct {
4747
NumNodes *int32
4848
NumProcPerNode string
49-
// TODO (andreyvelich). Potentially, we can use map for env and sort it to improve code.
50-
// Context: https://github.com/kubeflow/trainer/pull/2308#discussion_r1823267183
51-
Env []corev1ac.EnvVarApplyConfiguration
52-
ContainerPort *corev1ac.ContainerPortApplyConfiguration
53-
Volumes []corev1ac.VolumeApplyConfiguration
54-
VolumeMounts []corev1ac.VolumeMountApplyConfiguration
49+
Env []corev1ac.EnvVarApplyConfiguration
50+
ContainerPort *corev1ac.ContainerPortApplyConfiguration
51+
Volumes []corev1ac.VolumeApplyConfiguration
52+
VolumeMounts []corev1ac.VolumeMountApplyConfiguration
5553
}
5654

5755
// TODO (andreyvelich): Potentially, we can add ScheduleTimeoutSeconds to the Scheduler for consistency.

0 commit comments

Comments
 (0)