Skip to content

Commit 4865ba0

Browse files
chore(plugin): Update appending args logic in jobset builder.
Signed-off-by: Electronic-Waste <[email protected]>
1 parent afa49c4 commit 4865ba0

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

pkg/runtime/framework/plugins/jobset/builder.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,6 @@ func (b *Builder) Trainer(info *runtime.Info, trainJob *trainer.TrainJob) *Build
127127
if command := jobTrainer.Command; command != nil {
128128
b.Spec.ReplicatedJobs[i].Template.Spec.Template.Spec.Containers[j].Command = command
129129
}
130-
if args := jobTrainer.Args; args != nil {
131-
b.Spec.ReplicatedJobs[i].Template.Spec.Template.Spec.Containers[j].Args = args
132-
}
133130
if resourcesPerNode := jobTrainer.ResourcesPerNode; resourcesPerNode != nil &&
134131
(resourcesPerNode.Limits != nil || resourcesPerNode.Requests != nil) {
135132
requirements := corev1ac.ResourceRequirements()
@@ -142,6 +139,10 @@ func (b *Builder) Trainer(info *runtime.Info, trainJob *trainer.TrainJob) *Build
142139
b.Spec.ReplicatedJobs[i].Template.Spec.Template.Spec.Containers[j].
143140
WithResources(requirements)
144141
}
142+
apply.UpsertArgs(
143+
&b.Spec.ReplicatedJobs[i].Template.Spec.Template.Spec.Containers[j].Args,
144+
jobTrainer.Args...,
145+
)
145146
apply.UpsertEnvVars(
146147
&b.Spec.ReplicatedJobs[i].Template.Spec.Template.Spec.Containers[j].Env,
147148
apply.EnvVars(jobTrainer.Env...)...,

0 commit comments

Comments
 (0)