Skip to content

Commit 16acf49

Browse files
author
Julius von Kohout (Corporate Development)
committed
remove legacy stuff
1 parent c78e038 commit 16acf49

File tree

3 files changed

+2
-39
lines changed

3 files changed

+2
-39
lines changed

common/istio-1-16/istio-install/base/kustomization.yaml

+1-4
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,4 @@ patchesStrategicMerge:
1414
- patches/service.yaml
1515
- patches/istio-configmap-disable-tracing.yaml
1616
- patches/disable-debugging.yaml
17-
# Disable this patch until we upgrade to kustomize to v4+
18-
# see https://github.com/kubeflow/manifests/issues/2325#issuecomment-1323909056
19-
# - patches/remove-pdb.yaml
20-
17+
- patches/remove-pdb.yaml

common/istio-cni-1-16/kustomization.yaml

+1-34
Original file line numberDiff line numberDiff line change
@@ -7,41 +7,8 @@
77
#tar xzf istio.tar.gz
88
#istio-${ISTIO_TAG}/bin/istioctl manifest generate --set values.pilot.autoscaleMin=1 --set values.gateways.istio-ingressgateway.autoscaleMin=1 --set components.cni.enabled=true --set components.cni.namespace=kube-system --set components.cni.tag=${ISTIO_TAG} --set values.global.proxy.resources.requests.cpu=10m --set tag=${ISTIO_TAG} > istio.yaml
99
#rm -rf istio-${ISTIO_TAG} istio.tar.gz
10-
11-
# sadly there is a bug such that the busybox image is not configurable in a proper way
12-
1310
apiVersion: kustomize.config.k8s.io/v1beta1
1411
kind: Kustomization
15-
1612
resources:
1713
- namespace.yaml
18-
- istio.yaml
19-
20-
patchesStrategicMerge:
21-
# Pentest enahncement: check port 15010 & 8080 in istiod: According to https://istio.io/latest/docs/ops/best-practices/security/#control-plane port 15010 is not that problematic (only resource discovery). Other parts of the documentation also say | 15010 | GRPC | XDS and CA services (Plaintext, only for secure networks) | We have a secure network layer and only XDS is served. Port 8080 is not listed in the service and even if it would be somehow reachable by IP it only "offers read access". Nevertheless we set ENABLE_DEBUG_ON_HTTP=false do disable it entirely.
22-
- |-
23-
apiVersion: apps/v1
24-
kind: Deployment
25-
metadata:
26-
name: istiod
27-
namespace: istio-system
28-
spec:
29-
template:
30-
spec:
31-
containers:
32-
- name: discovery
33-
env:
34-
- name: ENABLE_DEBUG_ON_HTTP
35-
value: 'false'
36-
# https://github.com/kubeflow/manifests/issues/2285
37-
- |-
38-
apiVersion: v1
39-
kind: Service
40-
metadata:
41-
name: istio-ingressgateway
42-
namespace: istio-system
43-
spec:
44-
type: ClusterIP
45-
46-
47-
14+
- istio.yaml

common/podsecuritypolicies/kustomization.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,3 @@ resources:
66
- restricted/kubeflow-restricted-psp.yaml
77
- restricted/kubeflow-restricted-clusterrole.yaml
88
- restricted/kubeflow-restricted-clusterrole-rolebinding.yaml
9-

0 commit comments

Comments
 (0)