feat: support reconciling suggestion volume regardless of resumePolicy for pbt

Author: a9p

examples/v1beta1/hp-tuning/simple-pbt.yaml

@@ -8,7 +8,6 @@ spec:
   maxTrialCount: 2
   parallelTrialCount: 2
   maxFailedTrialCount: 3
-  resumePolicy: FromVolume
   objective:
     type: maximize
     goal: 0.99

pkg/controller.v1beta1/suggestion/suggestion_controller.go

@@ -47,6 +47,7 @@ import (
 const (
 	ControllerName = "suggestion-controller"
 )
+var ReconcileSuggestionVolumeOverrides = [...] string {"pbt"}
 
 var log = logf.Log.WithName(ControllerName)
 
@@ -191,8 +192,17 @@ func (r *ReconcileSuggestion) ReconcileSuggestion(instance *suggestionsv1beta1.S
 	suggestionNsName := types.NamespacedName{Name: instance.GetName(), Namespace: instance.GetNamespace()}
 	logger := log.WithValues("Suggestion", suggestionNsName)
 
+	// Check if requested algorithm is in reconcile override list
+	isReconcileOverride := false
+	for _, algorithmName := range ReconcileSuggestionVolumeOverrides {
+		if algorithmName == instance.Spec.Algorithm.AlgorithmName {
+			isReconcileOverride = true
+			break
+		}
+	}
+
 	// If ResumePolicy = FromVolume volume is reconciled for suggestion
-	if instance.Spec.ResumePolicy == experimentsv1beta1.FromVolume {
+	if isReconcileOverride || instance.Spec.ResumePolicy == experimentsv1beta1.FromVolume {
 		pvc, pv, err := r.DesiredVolume(instance)
 		if err != nil {
 			return err