Introduced cmp for error comparison for util.ConvertStringToUnstructured

tariq-hasan · tariq-hasan · commit ce090540f9f2 · 2024-04-16T01:13:10.000-04:00
Signed-off-by: tariq-hasan &lt;mmtariquehsn@gmail.com&gt;
diff --git a/pkg/controller.v1beta1/experiment/manifest/generator_test.go b/pkg/controller.v1beta1/experiment/manifest/generator_test.go
@@ -236,8 +236,8 @@ spec:
             - "--momentum=0.9"`
 
 	expectedRunSpec, err := util.ConvertStringToUnstructured(expectedStr)
-	if err != nil {
-		t.Errorf("%v: %v", errConvertStringToUnstructuredFailed, err)
+	if diff := cmp.Diff(nil, err, cmpopts.EquateErrors()); len(diff) != 0 {
+		t.Errorf("ConvertStringToUnstructured failed (-want,+got):\n%s", diff)
 	}
 
 	cases := map[string]struct {

Original file line number	Diff line number	Diff line change
`@@ -236,8 +236,8 @@ spec:`
`236`	`236`	- "--momentum=0.9"`
`237`	`237`
`238`	`238`	`expectedRunSpec, err := util.ConvertStringToUnstructured(expectedStr)`
`239`		`- if err != nil {`
`240`		`- t.Errorf("%v: %v", errConvertStringToUnstructuredFailed, err)`
	`239`	`+ if diff := cmp.Diff(nil, err, cmpopts.EquateErrors()); len(diff) != 0 {`
	`240`	`+ t.Errorf("ConvertStringToUnstructured failed (-want,+got):\n%s", diff)`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`cases := map[string]struct {`