Skip to content

Commit 87a6abc

Browse files
committed
Ordered test cases in TestGetRunSpecWithHPConfigMap
Signed-off-by: tariq-hasan <[email protected]>
1 parent ceebe09 commit 87a6abc

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

pkg/controller.v1beta1/experiment/manifest/generator_test.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,15 @@ spec:
312312
},
313313
}
314314

315-
for name, tc := range cases {
315+
testCaseNames := []string{
316+
"Run with valid parameters",
317+
"Invalid ConfigMap name",
318+
"Invalid template path in ConfigMap name",
319+
"Invalid trial spec in ConfigMap",
320+
}
321+
322+
for _, name := range testCaseNames {
323+
tc := cases[name]
316324
t.Run(name, func(t *testing.T) {
317325
got, err := p.GetRunSpecWithHyperParameters(tc.Instance, "trial-name", "trial-namespace", tc.ParameterAssignments)
318326
if diff := cmp.Diff(tc.wantError, err, cmpopts.EquateErrors()); len(diff) != 0 {

0 commit comments

Comments
 (0)